Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates specific domain references into broader ecosystem categories by introducing two new ecosystem identifiers: fonts (for Google Fonts domains) and node-cdns (for jsDelivr CDN). This simplifies domain management and makes workflow configurations more semantic and maintainable.
Changes:
- Added
fontsecosystem containingfonts.googleapis.comandfonts.gstatic.com - Added
node-cdnsecosystem containingcdn.jsdelivr.net - Updated mcp-inspector workflow to use new ecosystem names instead of literal domains
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/workflow/data/ecosystem_domains.json | Added fonts and node-cdns ecosystem definitions with their respective domains |
| pkg/workflow/domains_test.go | Added test cases to verify GetDomainEcosystem correctly identifies the new ecosystems and that GetAllowedDomains expands them properly |
| .github/workflows/mcp-inspector.md | Replaced three literal domain entries with two ecosystem identifiers (fonts and node-cdns) in the network allowed list |
| .github/workflows/mcp-inspector.lock.yml | Compiled workflow file reflecting the domain changes, but also contains significant unrelated changes including sparse checkout steps, local action setup, CLI/Docker builds, container configuration changes, and field removals |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 16, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
cdn.jsdelivr.net,fonts.googleapis.com, andfonts.gstatic.cominto broader ecosystem categoriesfontsandnode-cdns