Conversation
Copilot stopped work on behalf of
pelikhan due to an error
February 16, 2026 21:58
Copilot stopped work on behalf of
pelikhan due to an error
February 16, 2026 21:58
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…ard compatibility Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace infer: false with disable-model-invocation: true
Rename Feb 16, 2026
infer: false to disable-model-invocation: true in custom agent frontmatter
pelikhan
approved these changes
Feb 16, 2026
pelikhan
deleted the
copilot/replace-infer-with-disable-model-invocation
branch
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request renames the infer: false frontmatter field to disable-model-invocation: true in custom agent files for improved semantic clarity. The field controls whether custom agents should make additional model invocations during execution.
Changes:
- Renamed field in 13 custom agent files (8 in
.github/agents/, 5 in.github/aw/) - Updated JSON schema to include both fields with deprecation notice for
infer - Modified parser validation to accept both field names for backward compatibility
- Updated test to use new field name
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/parser/schemas/main_workflow_schema.json | Added disable-model-invocation field definition and marked infer as deprecated |
| pkg/parser/include_processor.go | Updated validation to accept both infer and disable-model-invocation field names |
| pkg/parser/frontmatter_includes_test.go | Renamed test function and updated test content to use new field name |
| .github/agents/*.agent.md (8 files) | Replaced infer: false with disable-model-invocation: true |
| .github/aw/*.md (5 files) | Replaced infer: false with disable-model-invocation: true |
| .github/workflows/*.lock.yml (3 files) | Updated frontmatter-hash values to reflect recompilation with changed agent imports |
Comments suppressed due to low confidence (1)
pkg/parser/frontmatter_includes_test.go:694
- The test was renamed from TestProcessIncludedFileWithInferField to TestProcessIncludedFileWithDisableModelInvocationField and now only tests the new field name. While the parser code correctly accepts both field names (line 173-174 in include_processor.go), there's no test coverage to verify that the deprecated 'infer' field continues to work. Consider adding a test case that verifies backward compatibility with 'infer: false' to ensure existing agent files continue to work without modification.
// TestProcessIncludedFileWithDisableModelInvocationField verifies that the "disable-model-invocation" field
// (used in custom agent format) is accepted without warnings
func TestProcessIncludedFileWithDisableModelInvocationField(t *testing.T) {
tempDir := t.TempDir()
agentsDir := filepath.Join(tempDir, ".github", "agents")
if err := os.MkdirAll(agentsDir, 0755); err != nil {
t.Fatalf("Failed to create agents directory: %v", err)
}
// Create a test file with the "disable-model-invocation" field (custom agent format)
testFile := filepath.Join(agentsDir, "test-agent.agent.md")
testContent := `---
name: Test Agent
description: A test custom agent
disable-model-invocation: true
---
# Test Agent
This is a custom agent file with the disable-model-invocation field.`
if err := os.WriteFile(testFile, []byte(testContent), 0644); err != nil {
t.Fatalf("Failed to write test file: %v", err)
}
// Process the included file - should not generate warnings
result, err := processIncludedFileWithVisited(testFile, "", false, make(map[string]bool))
if err != nil {
t.Fatalf("processIncludedFileWithVisited() error = %v", err)
}
if !strings.Contains(result, "# Test Agent") {
t.Errorf("Expected markdown content not found in result")
}
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Ok
في الاثنين، ١٦ فبراير ٢٠٢٦، ٢٢:٢٢ Peli de Halleux ***@***.***>
كتب:
… Merged #16221 <#16221> into main.
—
Reply to this email directly, view it on GitHub
<#16221 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/B2DFN3UC3RGZOSRUJMZ4FBT4MI7LFAVCNFSM6AAAAACVKTOWN6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRSHAZTMOBVGY4TMMI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
infer: falsefield in custom agent files was unclear. Renamed todisable-model-invocation: truefor semantic clarity.Changes
.github/agents/and 5 files in.github/aw/to use new field namedisable-model-invocationfield tomain_workflow_schema.jsonwith proper descriptioninferfield validation (marked deprecated) to avoid breaking existing agent filesinclude_processor.goto accept both field names in validationExample
Both field names are accepted. Existing files with
infer: falsecontinue to work unchanged.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphql/usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name x_amd64/compile(http block)/usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name 0/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/node(http block)/usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name ules/.bin/node(http block)https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1/usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha ithub-script/git/ref/tags/v8 64/pkg/tool/linuorigin /usr/bin/gcc(http block)https://api.github.com/repos/actions/checkout/git/ref/tags/v3/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha 1887448779 x_amd64/vet .cfg ys.md(http block)https://api.github.com/repos/actions/checkout/git/ref/tags/v4/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha prettier --write /opt/hostedtoolcache/node/24.13.0/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/n--show-toplevel **/*.ts **/*.json --ignore-path sh -c runs/20260216-220348-13917/test-1946567455 64/pkg/tool/linu-v /bin/sh tierignore .cfg 64/pkg/tool/linu--show-toplevel /bin/sh(http block)Co-authored-by: pelikhrev-parse /opt/hostedtoolcache/go/1.25.0/x64/bin/go` (http block)
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.