Conversation
This was referenced Feb 17, 2026
…erprise compatibility Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix workflow compiler to avoid adding discussions permission
Skip discussions permission in all:read expansion for GHE compatibility
Feb 17, 2026
Contributor
|
lint go, recompile |
Contributor
|
Use the following envs to resolve: GITHUB_SERVER_URL: https://MYORG.ghe.com do not use github_api_url update code in gh helpers that also resolve host, centralize helpers |
- Create centralized gitutil.GetGitHubHost() function - Support environment variables in priority order: 1. GITHUB_SERVER_URL (e.g., https://MYORG.ghe.com) 2. GITHUB_ENTERPRISE_HOST (e.g., MYORG.ghe.com) 3. GITHUB_HOST (e.g., MYORG.ghe.com) 4. GH_HOST (e.g., MYORG.ghe.com) - Add https:// prefix if not present (http:// or https://) - Remove trailing slashes - Default to https://github.com if no env vars set - Update pkg/cli/github.go to use centralized function - Add comprehensive tests for all environment variables - Tests verify priority order, URL normalization, and edge cases Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
Completed in commit 286066c:
The linter requires
Centralized in commit 286066c: Created
Updated ✅ 32 tests added and passing Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
pelikhan
reviewed
Feb 17, 2026
pkg/cli/github.go
Outdated
|
|
||
| // Remove trailing slash for consistency | ||
| return strings.TrimSuffix(host, "/") | ||
| return gitutil.GetGitHubHost() |
Contributor
There was a problem hiding this comment.
@copilot the helper source code belongs here, it is a GitHub feature
Contributor
Author
There was a problem hiding this comment.
Moved to pkg/cli/github.go in commit a9c9536. The GitHub host resolution is now implemented directly in the CLI package where GitHub-specific features belong.
… GitHub host resolution for GHE Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Skip discussions permission in all:read expansion for GHE compatibility
Fix: Skip discussions permission in all:read expansion and centralize GitHub host resolution for GHE
Feb 17, 2026
Contributor
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Fix: Skip discussions permission in all:read expansion and centralize GitHub host resolution for GHE
Fix: Skip discussions permission in all:read expansion and enhance GitHub host resolution for GHE
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two GitHub Enterprise compatibility issues:
permissions: all: readunconditionally expands to all scopes includingdiscussions: read, breaking GitHub Enterprise deployments without discussions enabled.Changes
Discussions Permission Fix
discussionsscope duringall: readexpansion unless explicitly present in permissions mapdiscussionsno longer auto-includedGitHub Host Resolution Enhancement
getGitHubHost()with full GitHub Enterprise environment variable supportBehavior
Permissions Before Fix
→ Expands to all scopes including
discussions: readPermissions After Fix
→ Expands to all scopes except
discussionsandid-tokenExplicit discussions permission still works:
→ Includes
discussions: readas expectedSafe-outputs that require discussions (
add-comment,create-discussion, etc.) continue to add the permission viacomputePermissionsForSafeOutputs().GitHub Host Resolution
Environment variables checked in priority order:
https://MYORG.ghe.com)MYORG.ghe.com)MYORG.ghe.com)MYORG.ghe.com)Defaults to
https://github.saobby.my.eu.orgif none are set.Testing
Compatibility
Improves GitHub Enterprise compatibility:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
✨ PR Review Safe Output Test - Run 22100482055