Skip to content

ci: build wasm compiler during docs deployment to fix live editor #16406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mossaka merged 2 commits into from
Feb 17, 2026
+23 −0
Merged

ci: build wasm compiler during docs deployment to fix live editor #16406

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed64e3f
ci: build wasm compiler during docs deployment to fix live editor
Mossaka Feb 17, 2026
f37e00a
fix: expand docs workflow path triggers per review
Mossaka Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,25 @@ on:
pull_request:
paths:
- 'docs/**'
- 'cmd/gh-aw-wasm/**'
- 'pkg/**'
- 'scripts/bundle-wasm-docs.sh'
Comment on lines 11 to +16
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull_request.paths / push.paths filters don’t include this workflow file itself. As a result, a PR that only changes .github/workflows/docs.yml (like this one) won’t trigger the docs build, which makes it hard to validate the workflow changes. Consider adding .github/workflows/docs.yml to both path lists.

Copilot uses AI. Check for mistakes.
- '.github/workflows/docs.yml'
- 'go.mod'
- 'go.sum'
- 'Makefile'
push:
branches:
- main
paths:
- 'docs/**'
- 'cmd/gh-aw-wasm/**'
- 'pkg/**'
- 'scripts/bundle-wasm-docs.sh'
Comment on lines 14 to 28
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path filters were expanded for Go/WASM-related changes, but they still won’t trigger on dependency/build-definition changes in the repo root (e.g. go.mod, go.sum, or Makefile). Since the WASM artifacts are produced via make build-wasm and depend on module state, consider adding these root files to both pull_request.paths and push.paths so docs rebuild when the WASM build inputs change.

Copilot uses AI. Check for mistakes.
- '.github/workflows/docs.yml'
- 'go.mod'
- 'go.sum'
- 'Makefile'

# Allow this job to clone the repo and create a page deployment
permissions:
Expand Down Expand Up @@ -43,6 +57,15 @@ jobs:
cache: 'npm'
cache-dependency-path: 'docs/package-lock.json'

- name: Set up Go
uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6
with:
go-version-file: go.mod
cache: true

- name: Build WebAssembly compiler for docs
run: ./scripts/bundle-wasm-docs.sh

- name: Install dependencies
working-directory: ./docs
run: npm ci
Expand Down