Skip to content

Comments

Fix testifylint violations in lock_schema_test.go#16451

Merged
pelikhan merged 3 commits intomainfrom
copilot/fix-lint-go-workflow-failure-again
Feb 17, 2026
Merged

Fix testifylint violations in lock_schema_test.go#16451
pelikhan merged 3 commits intomainfrom
copilot/fix-lint-go-workflow-failure-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 17, 2026

The lint-go workflow was failing on 10 testifylint violations in pkg/workflow/lock_schema_test.go.

Changes

  • Error assertions: Changed assert.Error/assert.NoErrorrequire.Error/require.NoError (9 instances)
    • testifylint enforces require.* for error assertions to fail fast on critical conditions
  • Empty checks: Changed assert.Equal(t, "", metadata.StopTime)assert.Empty(t, metadata.StopTime) (1 instance)
    • testifylint enforces semantic clarity for empty value assertions
// Before
assert.NoError(t, err, "Should parse legacy lock file")
assert.Equal(t, "", metadata.StopTime, "Stop time should be empty")

// After
require.NoError(t, err, "Should parse legacy lock file")
assert.Empty(t, metadata.StopTime, "Stop time should be empty")

All changes are linter compliance fixes with no functional impact.

Original prompt

Fix the failing GitHub Actions workflow lint-go
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 63926118092
Job URL: https://github.com/github/gh-aw/actions/runs/22116568757/job/63926118092


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions workflow lint-go Fix testifylint violations in lock_schema_test.go Feb 17, 2026
Copilot AI requested a review from pelikhan February 17, 2026 21:47
@pelikhan pelikhan marked this pull request as ready for review February 17, 2026 21:48
Copilot AI review requested due to automatic review settings February 17, 2026 21:48
@pelikhan pelikhan merged commit c9b7577 into main Feb 17, 2026
53 of 54 checks passed
@pelikhan pelikhan deleted the copilot/fix-lint-go-workflow-failure-again branch February 17, 2026 21:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses lint-go failures by updating pkg/workflow/lock_schema_test.go to comply with testifylint’s preferred assertion patterns, without changing test behavior.

Changes:

  • Switched error assertions from assert.Error/assert.NoError to require.Error/require.NoError where fail-fast behavior is expected.
  • Replaced an empty-string equality check with assert.Empty for semantic clarity.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants