Fix testifylint violations in lock_schema_test.go#16451
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow lint-go
Fix testifylint violations in lock_schema_test.go
Feb 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses lint-go failures by updating pkg/workflow/lock_schema_test.go to comply with testifylint’s preferred assertion patterns, without changing test behavior.
Changes:
- Switched error assertions from
assert.Error/assert.NoErrortorequire.Error/require.NoErrorwhere fail-fast behavior is expected. - Replaced an empty-string equality check with
assert.Emptyfor semantic clarity.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lint-goworkflow was failing on 10 testifylint violations inpkg/workflow/lock_schema_test.go.Changes
assert.Error/assert.NoError→require.Error/require.NoError(9 instances)require.*for error assertions to fail fast on critical conditionsassert.Equal(t, "", metadata.StopTime)→assert.Empty(t, metadata.StopTime)(1 instance)All changes are linter compliance fixes with no functional impact.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.