Skip to content

Comments

[WIP] Fix failing GitHub Actions workflow lint-go#16468

Merged
pelikhan merged 3 commits intomainfrom
copilot/fix-lint-go-workflow-failure-again
Feb 17, 2026
Merged

[WIP] Fix failing GitHub Actions workflow lint-go#16468
pelikhan merged 3 commits intomainfrom
copilot/fix-lint-go-workflow-failure-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 17, 2026

Fix lint-go workflow failure

  • Investigate failing lint-go workflow job (63934776261)
  • Identify root cause: testifylint error in compiler_string_api_test.go line 229
  • Fix assertion to use assert.NotContains instead of assert.False(strings.Contains)
  • Remove unused strings import
  • Verify tests pass
  • Run make fmt
  • Run make agent-finish to ensure all checks pass
Original prompt

Fix the failing GitHub Actions workflow lint-go
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 63934776261
Job URL: https://github.com/github/gh-aw/actions/runs/22119141337/job/63934776261


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits February 17, 2026 23:49
@pelikhan pelikhan marked this pull request as ready for review February 17, 2026 23:52
Copilot AI review requested due to automatic review settings February 17, 2026 23:52
@pelikhan pelikhan merged commit 3975e57 into main Feb 17, 2026
52 checks passed
@pelikhan pelikhan deleted the copilot/fix-lint-go-workflow-failure-again branch February 17, 2026 23:52
Copilot AI requested a review from pelikhan February 17, 2026 23:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a failing lint-go GitHub Actions workflow by addressing a testifylint violation in the test suite. The issue was caused by using assert.False(strings.Contains(...)) which testifylint flags as an anti-pattern when more specific assertion methods like assert.NotContains are available.

Changes:

  • Replaced assert.False(t, strings.Contains(yaml, "Agentic")) with assert.NotContains(t, yaml, "Agentic") in test
  • Removed unused strings import from the test file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants