Make parent "Failed runs" issue creation opt-in via group-reports flag#16715
Make parent "Failed runs" issue creation opt-in via group-reports flag#16715
Conversation
|
@copilot rename flag |
- Added ReportsParentIssues field to SafeOutputsConfig - Updated parser to extract reports-parent-issues flag from frontmatter - Pass flag as GH_AW_REPORTS_PARENT_ISSUES env var to failure handler - Modified handle_agent_failure.cjs to check flag before creating parent issues - Added initial tests for the new flag - Updated existing tests that require parent issues to enable the flag Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Added reports-parent-issues field to JSON schema - Updated test files to work with new default behavior - Verified compilation works with both true/false values - Schema correctly validates the new boolean field Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Renamed YAML key: reports-parent-issues → group-reports - Renamed Go field: ReportsParentIssues → GroupReports - Renamed env var: GH_AW_REPORTS_PARENT_ISSUES → GH_AW_GROUP_REPORTS - Updated schema, tests, and all workflow lock files - Flag behavior unchanged: defaults to false, creates parent issue when true Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Renamed to Changes:
All workflow lock files regenerated with the new environment variable name. |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
🧪 Smoke Temporary ID is now testing temporary ID functionality... |
|
🧪 Smoke Project is now testing project operations... |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
There was a problem hiding this comment.
Pull request overview
This pull request makes parent "[agentics] Failed runs" issue creation opt-in via a new group-reports boolean flag in the safe-outputs frontmatter configuration. Previously, parent issues were created automatically for all agent failures, which cluttered issue lists in smaller repositories.
Changes:
- Added
group-reportsboolean field to safe-outputs configuration (defaults to false) - Updated compiler to pass
GH_AW_GROUP_REPORTSenvironment variable to the failure handler - Modified failure handler to check the flag before creating parent issues
- Updated tests to explicitly enable the flag where parent issues are expected and added comprehensive tests for the three flag states (disabled, enabled, unset)
Reviewed changes
Copilot reviewed 151 out of 151 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/compiler_types.go | Added GroupReports boolean field to SafeOutputsConfig struct |
| pkg/workflow/safe_outputs_config.go | Added parser logic to extract group-reports flag from frontmatter |
| pkg/parser/schemas/main_workflow_schema.json | Added schema definition for group-reports field with validation |
| pkg/workflow/notify_comment.go | Updated compiler to pass GH_AW_GROUP_REPORTS env var to failure handler |
| actions/setup/js/handle_agent_failure.cjs | Modified to check GH_AW_GROUP_REPORTS flag before creating parent issues |
| actions/setup/js/handle_agent_failure.test.cjs | Updated existing tests and added new tests for flag behavior |
| .github/workflows/*.lock.yml | Generated workflow files updated to include environment variable (but with incorrect name) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ Smoke Project completed successfully. All project operations validated. |
|
Smoke test results:
|
|
🤖 Smoke test §22166207374 results for
Overall:
|
There was a problem hiding this comment.
Smoke test review: The PR consistently adds GH_AW_REPORTS_PARENT_ISSUES: "false" across all lock files, correctly implementing opt-in behavior for parent issue creation. Lock files appear to be properly compiled from the source markdown changes.
📰 BREAKING: Report filed by Smoke Copilot for issue #16715
| GH_AW_CREATE_DISCUSSION_ERROR_COUNT: ${{ needs.safe_outputs.outputs.create_discussion_error_count }} | ||
| GH_AW_REPO_MEMORY_VALIDATION_FAILED_default: ${{ needs.push_repo_memory.outputs.validation_failed_default }} | ||
| GH_AW_REPO_MEMORY_VALIDATION_ERROR_default: ${{ needs.push_repo_memory.outputs.validation_error_default }} | ||
| GH_AW_REPORTS_PARENT_ISSUES: "false" |
There was a problem hiding this comment.
This new GH_AW_REPORTS_PARENT_ISSUES: "false" env variable effectively makes parent issue creation opt-in. Looks correct — defaulting to "false" prevents cluttering issue lists in smaller repositories.
| GH_AW_CHECKOUT_PR_SUCCESS: ${{ needs.agent.outputs.checkout_pr_success }} | ||
| GH_AW_CREATE_DISCUSSION_ERRORS: ${{ needs.safe_outputs.outputs.create_discussion_errors }} | ||
| GH_AW_CREATE_DISCUSSION_ERROR_COUNT: ${{ needs.safe_outputs.outputs.create_discussion_error_count }} | ||
| GH_AW_REPORTS_PARENT_ISSUES: "false" |
There was a problem hiding this comment.
Same opt-in pattern applied consistently across workflows. Good to see all lock files updated in a single PR to keep them in sync.
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 Serena MCP investigation complete. Serena is a built-in MCP tool in gh-aw (not a standalone callable server), so direct activation and find_symbol calls are not possible from this environment. |
|
Smoke Test Results - Run §22166207471 Core tests: ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ Overall: PARTIAL (2 skipped, 0 failed)
|
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
💥 [THE END] — Illustrated by Smoke Claude for issue #16715
…tests 8 tests were failing because they still had parent issue search/create mocks from before group-reports defaulted to false. Fixed by: - Removing parent issue mocking from 6 edge case tests (handle missing env vars, truncate long names, expiration comment, PR info, branch info) - Adding GH_AW_GROUP_REPORTS=true to 2 tests that intentionally test with parent issue creation (create_discussion errors, missing_data) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Fixed in commit d5120f8. 8 tests were failing because they still had stale parent issue mocking (3 searches + 2 creates) from before
All 29 tests now pass. |
Implementation Complete: Group Reports Flag
This PR makes parent "[agentics] Failed runs" issue creation opt-in via the
group-reportsflag.group-reportsboolean field tosafe-outputsfrontmatterfalse(no parent issue created)true, creates parent issue and links failures as sub-issuesGH_AW_GROUP_REPORTSenv var to failure handlerUsage
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
✨ PR Review Safe Output Test - Run 22166207471
Changeset
group-reportsflag instead of creating parent issues automatically.