ci: move TestDockerImage tests into CLI Docker Build group#16837
Merged
ci: move TestDockerImage tests into CLI Docker Build group#16837
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Move TestDockerImage tests into CLI Docker Build group
ci: move TestDockerImage tests into CLI Docker Build group
Feb 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI integration test matrix to move slow TestDockerImage* integration tests into the existing Docker-focused group, reducing the duration of the catch-all CLI job on the integration critical path.
Changes:
- Expanded the CLI Docker Build group pattern to include
TestDockerImage*tests alongsideTestDockerBuild*. - Updated the CLI Completion & Other catch-all exclusions to skip
TestDockerImage*. - Refreshed the timing annotation comment for the Docker test group.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestDockerImage_RunsSuccessfully(~43s) andTestDockerImage_HasRequiredTools(~3s) were left in the "CLI Completion & Other" catch-all, making it the slowest integration matrix job at ~53s. These tests share Docker infrastructure withTestDockerBuildand belong in the same group.Changes
CLI Docker Buildpattern:TestDockerBuild→TestDockerBuild|TestDockerImageCLI Completion & Otherskip_pattern: addedTestDockerImageto exclusion list~38s→~43sResult: catch-all drops from ~53s → ~10s on the integration critical path; Docker group stays at ~43s wall-clock (tests run concurrently via
-parallel=8).Original prompt
This section details on the original issue you should resolve
<issue_title>[ci-coach] ci: move TestDockerImage tests into CLI Docker Build group</issue_title>
<issue_description>### Summary
TestDockerImage_RunsSuccessfully(~43s) andTestDockerImage_HasRequiredTools(~3s) were accidentally left in the "CLI Completion & Other" catch-all group, making it the slowest integration matrix job at 53.2s. Moving them to the existing "CLI Docker Build" group (which already isolates slow Docker tests) reduces the catch-all from ~53s to ~10s.Optimization
1. Move TestDockerImage tests to CLI Docker Build group
Type: Test Suite Restructuring
Impact: ~10s reduction in integration critical path (53s → 43s)
Risk: Low — only changes test grouping, not test logic
Changes:
CLI Docker Buildpattern:TestDockerBuild→TestDockerBuild|TestDockerImageCLI Completion & Otherskip_pattern: addedTestDockerImageto exclusion listRationale:
TestDockerBuildwas already isolated because it takes ~41s.TestDockerImage_RunsSuccessfullyalso takes ~43s and shares the same Docker infrastructure — it belongs in the same group. Since all tests in a group run with-parallel=8, the Docker tests execute concurrently, keeping wall-clock time at ~43s while eliminating the bottleneck in the catch-all.Before/After Timing Comparison
Before:
After (estimated):
Critical path improvement: 53.2s → ~43s (~10s faster)
Expected Impact
Validation Results
✅ YAML syntax validated (Python yaml.safe_load)
✅ Change is minimal and surgical (3 lines)
Testing Plan
Metrics Baseline (Run github/gh-aw#79)
Proposed by CI Coach workflow run github/gh-aw#79
To apply the patch locally:
Show patch preview (44 of 44 lines)