Skip to content

Comments

ci: move TestDockerImage tests into CLI Docker Build group#16837

Merged
pelikhan merged 2 commits intomainfrom
copilot/move-test-dockerimage-tests
Feb 19, 2026
Merged

ci: move TestDockerImage tests into CLI Docker Build group#16837
pelikhan merged 2 commits intomainfrom
copilot/move-test-dockerimage-tests

Conversation

Copy link
Contributor

Copilot AI commented Feb 19, 2026

TestDockerImage_RunsSuccessfully (~43s) and TestDockerImage_HasRequiredTools (~3s) were left in the "CLI Completion & Other" catch-all, making it the slowest integration matrix job at ~53s. These tests share Docker infrastructure with TestDockerBuild and belong in the same group.

Changes

  • CLI Docker Build pattern: TestDockerBuildTestDockerBuild|TestDockerImage
  • CLI Completion & Other skip_pattern: added TestDockerImage to exclusion list
  • Comment: updated timing annotation from ~38s~43s

Result: catch-all drops from ~53s → ~10s on the integration critical path; Docker group stays at ~43s wall-clock (tests run concurrently via -parallel=8).

Original prompt

This section details on the original issue you should resolve

<issue_title>[ci-coach] ci: move TestDockerImage tests into CLI Docker Build group</issue_title>
<issue_description>### Summary

TestDockerImage_RunsSuccessfully (~43s) and TestDockerImage_HasRequiredTools (~3s) were accidentally left in the "CLI Completion & Other" catch-all group, making it the slowest integration matrix job at 53.2s. Moving them to the existing "CLI Docker Build" group (which already isolates slow Docker tests) reduces the catch-all from ~53s to ~10s.

Optimization

1. Move TestDockerImage tests to CLI Docker Build group

Type: Test Suite Restructuring
Impact: ~10s reduction in integration critical path (53s → 43s)
Risk: Low — only changes test grouping, not test logic

Changes:

  • CLI Docker Build pattern: TestDockerBuildTestDockerBuild|TestDockerImage
  • CLI Completion & Other skip_pattern: added TestDockerImage to exclusion list
  • Updated comment to reflect new combined group timing (~43s)

Rationale: TestDockerBuild was already isolated because it takes ~41s. TestDockerImage_RunsSuccessfully also takes ~43s and shares the same Docker infrastructure — it belongs in the same group. Since all tests in a group run with -parallel=8, the Docker tests execute concurrently, keeping wall-clock time at ~43s while eliminating the bottleneck in the catch-all.

Before/After Timing Comparison

Before:

Group Duration Tests
CLI Completion & Other (slowest) 53.2s 288
CLI Docker Build 41.4s 1

After (estimated):

Group Duration Tests
CLI Docker Build ~43s 3
CLI Completion & Other ~10s ~126

Critical path improvement: 53.2s → ~43s (~10s faster)

Expected Impact

  • Total Time Savings: ~10s per CI run on the integration critical path
  • Risk Level: Low — no test logic changed, only grouping

Validation Results

✅ YAML syntax validated (Python yaml.safe_load)
✅ Change is minimal and surgical (3 lines)

Testing Plan

  • Verify "CLI Docker Build" group now runs all 3 Docker tests and passes
  • Verify "CLI Completion & Other" no longer contains slow Docker tests
  • Monitor first few runs to confirm timing improvements

Metrics Baseline (Run github/gh-aw#79)

  • Success rate: 57% (out of 100 recent runs)
  • Unit test duration: 53.3s
  • Integration critical path before: 53.2s ("CLI Completion & Other")
  • Total integration groups: 30

Proposed by CI Coach workflow run github/gh-aw#79

AI generated by CI Optimization Coach

  • expires on Feb 21, 2026, 1:44 PM UTC

[!NOTE]
This was originally intended as a pull request, but the git push operation failed.

Workflow Run: View run details and download patch artifact

The patch file is available in the agent-artifacts artifact in the workflow run linked above.

To apply the patch locally:

# Download the artifact from the workflow run https://github.com/github/gh-aw/actions/runs/22183771031
# (Use GitHub MCP tools if gh CLI is not available)
gh run download 22183771031 -n agent-artifacts

# The patch file will be at agent-artifacts/tmp/gh-aw/aw.patch after download
# Apply the patch
git am agent-artifacts/tmp/gh-aw/aw.patch
Show patch preview (44 of 44 lines)
From ca1eacae9def754599e9a3efd974d015e1cf7322 Mon Sep 17 00:00:00 2001
From: CI Coach <ci-coach@github.com>
Date: Thu, 19 Feb 2026 13:39:04 +0000
Subject: [PATCH] ci: move TestDockerImage tests into CLI Docker Build group

TestDockerImage_RunsSuccessfully (~43s) and TestDockerImage_HasRequiredTools
(~3s) were in the catch-all 'CLI Completion & Other' group, making it the
slowest integration group at ~53s.

Moving them to the 'CLI Docker Build' group (which already isolates slow
Docker tests) reduces the catch-all from ~53s to ~10s. The Docker group
runs all tests in parallel so wall-clock stays ~43s, cutting the integration
critical path by ~10s.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 .github/workflows/ci.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 8279c5f..b8f00b6 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -203,13 +203,13 @@ jobs:
           - name: "CLI Audit & Inspect"
             packages: "./pkg/cli"
             pattern: "^TestAudit|^TestInspect"
-          - name: "CLI Docker Build"  # Isolate slow Docker build test (~38s)
+          - name: "CLI Docker Build" ...

</details>



<!-- START COPILOT CODING AGENT SUFFIX -->

- Fixes github/gh-aw#16829

<!-- START COPILOT CODING AGENT TIPS -->
---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. [Learn more about Advanced Security.](https://gh.io/cca-advanced-security)

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Move TestDockerImage tests into CLI Docker Build group ci: move TestDockerImage tests into CLI Docker Build group Feb 19, 2026
@pelikhan pelikhan marked this pull request as ready for review February 19, 2026 14:20
Copilot AI review requested due to automatic review settings February 19, 2026 14:20
@pelikhan pelikhan merged commit 3183795 into main Feb 19, 2026
91 checks passed
@pelikhan pelikhan deleted the copilot/move-test-dockerimage-tests branch February 19, 2026 14:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CI integration test matrix to move slow TestDockerImage* integration tests into the existing Docker-focused group, reducing the duration of the catch-all CLI job on the integration critical path.

Changes:

  • Expanded the CLI Docker Build group pattern to include TestDockerImage* tests alongside TestDockerBuild*.
  • Updated the CLI Completion & Other catch-all exclusions to skip TestDockerImage*.
  • Refreshed the timing annotation comment for the Docker test group.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants