Fix footer spacing in Playground editor#17039
Conversation
Replace Primer's `gap-2` utility class with explicit inline `gap: 6px` on the footer flex containers. The Primer class was not reliably applying spacing between the text, heart SVG, and link elements, causing them to render smashed together (e.g., "Made with💜byGitHub Next&Microsoft Research"). Also add `flex-shrink: 0` to the heart SVG to prevent it from collapsing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a visual spacing bug in the Playground editor footer where text, emoji, and links were rendering without spaces between them. The issue was caused by Primer CSS's gap-2 utility class not reliably applying horizontal spacing between mixed inline flex children.
Changes:
- Replaced
gap-2class with inlinestyle="gap: 6px"on both footer row containers for reliable horizontal spacing - Added
flex-shrink: 0to the heart SVG to prevent it from collapsing under flex layout constraints
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hey Process ViolationThis repository requires all contributions to go through an agentic plan workflow. According to CONTRIBUTING.md:
The expected workflow is:
Technical Feedback
What to doIf you'd like to align with the standard process, consider:
|
Summary
Root Cause
Primer CSS's
gap-2utility class was not reliably applying spacing between the inline flex children (text spans, SVG, and anchor elements).Fix
gap-2class with explicit inlinestyle="gap: 6px"on both footer rowsflex-shrink: 0on the heart SVG to prevent it from collapsingTest plan
🤖 Generated with Claude Code