Skip to content

Fix footer spacing in Playground editor#17039

Merged
Mossaka merged 1 commit intomainfrom
fix/footer-spacing
Feb 20, 2026
Merged

Fix footer spacing in Playground editor#17039
Mossaka merged 1 commit intomainfrom
fix/footer-spacing

Conversation

@Mossaka
Copy link
Collaborator

@Mossaka Mossaka commented Feb 20, 2026

Summary

  • Fix missing whitespace between text, heart emoji, and links in the Playground editor footer
  • The footer was rendering as "Made with💜byGitHub Next&Microsoft Research" with no spaces

Root Cause

Primer CSS's gap-2 utility class was not reliably applying spacing between the inline flex children (text spans, SVG, and anchor elements).

Fix

  • Replace gap-2 class with explicit inline style="gap: 6px" on both footer rows
  • Add flex-shrink: 0 on the heart SVG to prevent it from collapsing

Test plan

  • Verify footer reads "Made with 💜 by GitHub Next & Microsoft Research" with proper spacing
  • Verify "Terms · Privacy · Security" links have consistent spacing
  • Check on mobile viewport

🤖 Generated with Claude Code

Replace Primer's `gap-2` utility class with explicit inline `gap: 6px`
on the footer flex containers. The Primer class was not reliably applying
spacing between the text, heart SVG, and link elements, causing them to
render smashed together (e.g., "Made with💜byGitHub Next&Microsoft Research").

Also add `flex-shrink: 0` to the heart SVG to prevent it from collapsing.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings February 20, 2026 01:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a visual spacing bug in the Playground editor footer where text, emoji, and links were rendering without spaces between them. The issue was caused by Primer CSS's gap-2 utility class not reliably applying horizontal spacing between mixed inline flex children.

Changes:

  • Replaced gap-2 class with inline style="gap: 6px" on both footer row containers for reliable horizontal spacing
  • Added flex-shrink: 0 to the heart SVG to prevent it from collapsing under flex layout constraints

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

Hey @Mossaka 👋 — thanks for tackling the footer spacing issue in the Playground editor! The fix looks good technically, but there's an important process concern:

Process Violation

This repository requires all contributions to go through an agentic plan workflow. According to CONTRIBUTING.md:

🚫 Traditional Pull Requests Are Not Enabled: You cannot create pull requests directly. Instead, you create detailed agentic plans in issues, and GitHub Copilot Agent will create and implement the PR for you after maintainer approval.

The expected workflow is:

  1. Create an issue with a detailed agentic plan describing the bug, root cause, and implementation steps
  2. Maintainer assigns the issue to GitHub Copilot Agent
  3. Agent creates the PR following your plan

Technical Feedback

  • Missing tests — While this is a visual UI fix that may not have automated test coverage, the test plan in the PR body lists manual verification steps that haven't been checked off yet.
  • Good description — The PR body has excellent detail about the summary, root cause, and fix approach.
  • Focused change — The diff is small and does exactly one thing.

What to do

If you'd like to align with the standard process, consider:

  1. Closing this PR
  2. Creating an issue with the same analysis from your PR body
  3. Letting the agentic workflow handle implementation

Generated by Contribution Check

@Mossaka Mossaka merged commit 16755c9 into main Feb 20, 2026
48 checks passed
@Mossaka Mossaka deleted the fix/footer-spacing branch February 20, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants