Skip to content

Relax brittle description assertion in live MCP registry integration test #17449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Feb 21, 2026
+5 −5
Merged

Relax brittle description assertion in live MCP registry integration test #17449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbcfef1
Initial plan
Copilot Feb 21, 2026
e6f153b
initial plan
Copilot Feb 21, 2026
de8c3a7
fix: relax brittle description assertion in live MCP registry test (#…
Copilot Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/cli/mcp_registry_live_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func TestMCPRegistryClient_LiveSearchServers(t *testing.T) {
t.Errorf("First server has empty name")
}
if firstServer.Description == "" {
t.Errorf("First server has empty description")
t.Logf("Warning: First server '%s' has empty description (field may be optional)", firstServer.Name)
}
if firstServer.Transport == "" {
t.Errorf("First server has empty transport")
Expand Down Expand Up @@ -153,7 +153,7 @@ func TestMCPRegistryClient_LiveGetServer(t *testing.T) {
t.Errorf("Expected server name '%s', got '%s'", serverName, server.Name)
}
if server.Description == "" {
t.Errorf("Server description is empty")
t.Logf("Warning: Server '%s' has empty description (field may be optional)", serverName)
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning for an empty Description logs serverName (the expected name) rather than the actual server.Name. If the preceding name assertion fails, this warning becomes misleading and makes debugging harder. Consider logging server.Name (or both expected/actual) in the warning message.

Suggested change
t.Logf("Warning: Server '%s' has empty description (field may be optional)", serverName)
t.Logf("Warning: Server (expected '%s', actual '%s') has empty description (field may be optional)", serverName, server.Name)

Copilot uses AI. Check for mistakes.
}
if server.Transport == "" {
t.Errorf("Server transport is empty")
Expand Down
6 changes: 3 additions & 3 deletions pkg/workflow/data/action_pins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,10 @@
"version": "v1.20.4",
"sha": "dff508cca8ce57162e7aa6c4769a4f97c2fed638"
},
"github/codeql-action/upload-sarif@v3.32.3": {
"github/codeql-action/upload-sarif@v3.32.4": {
"repo": "github/codeql-action/upload-sarif",
"version": "v3.32.3",
"sha": "17ec405481c24be464d4b2c5727a82f700ddb189"
"version": "v3.32.4",
"sha": "85b88275909735f5bc23196090e03d2eb148b3de"
Comment on lines +158 to +161
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description lists only pkg/cli/mcp_registry_live_test.go as changed, but this PR also updates pkg/workflow/data/action_pins.json (CodeQL upload-sarif pin). Please update the PR description to mention this additional change, or drop it from the PR if it’s unrelated to the MCP registry test fix.

Copilot uses AI. Check for mistakes.
},
"github/stale-repos@v3.0.2": {
"repo": "github/stale-repos",
Expand Down