[tidy] Fix linting issues in notify_comment_error.test.cjs#2026
Closed
[tidy] Fix linting issues in notify_comment_error.test.cjs#2026
Conversation
- Fixed duplicate body keys in expect.objectContaining() calls - Changed to use expect.stringMatching() with regex patterns - All tests passing and linting validated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed JavaScript linting issues in the test file
notify_comment_error.test.cjsthat were preventing the codebase from passing linting checks.Changes Made
Fixed Duplicate Object Keys
body:keys inexpect.objectContaining()calls, which is invalid JavaScript syntaxexpect.stringMatching()with regex patterns to match multiple string patterns in a single assertionSpecific Changes
✅.*completed successfully❌.*failed.*wasn't able to produce a result🚫.*was cancelled⏱️.*timed out⏭️.*was skipped✅.*completed successfully❌.*failedValidation
make fmt- All code properly formattedmake lint- All linting checks passingmake test- All tests passing (including the modified test file)make recompile- All workflows recompiled successfullyBefore & After
Before (Invalid - Duplicate Keys):
After (Valid - Regex Pattern):
Impact
This change ensures the codebase passes all linting checks and maintains code quality standards. The test functionality remains identical - the assertions still verify the same behavior, just with cleaner syntax.