Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 23, 2025

This PR removes the defaults section from the main workflow schema (main_workflow_schema.json). This section was intended for GitHub Actions workflow defaults (default shell and working directory) but was not being used in any workflows and added unnecessary complexity to the schema.

Changes

Schema Updates:

  • Removed the top-level defaults property definition from main_workflow_schema.json (lines 1073-1094)
  • Removed the $ref reference to defaults within the jobs section (lines 1197-1199)

Code Updates:

  • Removed defaults from PriorityJobFields constant in pkg/constants/constants.go
  • Removed test cases for the defaults field in pkg/parser/schema_test.go

Documentation:

  • Auto-generated schema documentation updated to remove the defaults section

Validation

The schema now correctly rejects workflows that attempt to use the defaults field:

$ ./gh-aw compile test-workflow.md
✗ failed to parse workflow file: error: Unknown property: defaults. 
Did you mean one of: imports, runtimes, services

Important Note: The defaults network access mode (e.g., network: defaults) is a completely separate feature and remains unchanged. This PR only removes the GitHub Actions workflow defaults section that was not being utilized.

Testing

  • ✅ All unit tests pass
  • ✅ All integration tests pass
  • ✅ All 67 workflows in the repository compile successfully
  • ✅ Schema validation correctly rejects the removed field
  • ✅ Network "defaults" mode still functions properly
  • ✅ Binary rebuilt with embedded schema changes
Original prompt

Remove "defaults" section from the main json schema.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 3 commits October 23, 2025 04:53
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Removed top-level "defaults" property definition (lines 1073-1094)
- Removed "$ref" to defaults within jobs section (lines 1197-1199)
- Removed "defaults" from PriorityJobFields constant in constants.go
- Removed test cases that used the defaults field
- All tests pass and workflows compile successfully

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove defaults section from main json schema Remove "defaults" section from main JSON schema Oct 23, 2025
Copilot AI requested a review from pelikhan October 23, 2025 05:04
@pelikhan pelikhan marked this pull request as ready for review October 23, 2025 05:11
@github-actions
Copy link
Contributor

Agentic Changeset Generator triggered by this pull request.

@pelikhan pelikhan merged commit 6b2c9e7 into main Oct 23, 2025
4 checks passed
@pelikhan pelikhan deleted the copilot/remove-defaults-section branch October 23, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants