Skip to content

[WIP] Fix mergeAt error by removing field filtering #2760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Oct 30, 2025
Merged

[WIP] Fix mergeAt error by removing field filtering #2760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21e7967
Initial plan
Copilot Oct 30, 2025
515c80d
Initial analysis: mergedAt field not supported by gh search prs
Copilot Oct 30, 2025
60afce0
Remove mergedAt field from gh search prs command
Copilot Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/copilot-pr-prompt-analysis.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions .github/workflows/copilot-pr-prompt-analysis.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ steps:
gh search prs --repo ${{ github.repository }} \
--author "app/copilot" \
--created ">=$DATE_30_DAYS_AGO" \
--json number,title,state,createdAt,closedAt,mergedAt,author,body,labels,url,assignees,repository \
--json number,title,state,createdAt,closedAt,author,body,labels,url,assignees,repository \
--limit 1000 \
> /tmp/gh-aw/pr-data/copilot-prs.json

Expand Down Expand Up @@ -116,17 +116,19 @@ For each PR in the dataset:
- Handle cases where body is null or empty

2. **Categorize the PR outcome**:
- **Merged**: `mergedAt` is not null
- **Closed (not merged)**: `state` is "CLOSED" and `mergedAt` is null
- **Note**: The `gh search prs` command doesn't return `mergedAt` in its JSON output
Copy link

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected backtick usage: should use backticks around the command name for consistency with other code references in the document.

Copilot uses AI. Check for mistakes.
- To determine merge status, you'll need to use `gh pr view <number> --json mergedAt` for each PR
Copy link

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The documentation instructs to check merge status for 'each PR', but this could be inefficient for large datasets (up to 1000 PRs). Consider adding a note about potential performance implications or suggesting batch processing strategies to avoid rate limiting.

Suggested change
- To determine merge status, you'll need to use `gh pr view <number> --json mergedAt` for each PR
- To determine merge status, you'll need to use `gh pr view <number> --json mergedAt` for each PR
- ⚠️ **Performance Note**: For large datasets (hundreds or thousands of PRs), checking merge status for each PR individually can be inefficient and may lead to GitHub API rate limiting. Consider batching requests, using the GitHub REST API to fetch multiple PRs at once, or limiting the number of PRs processed in a single run.

Copilot uses AI. Check for mistakes.
- **Merged**: Use `gh pr view` to check if `mergedAt` is not null
- **Closed (not merged)**: `state` is "CLOSED" and PR was not merged
- **Open**: `state` is "OPEN"

3. **Extract key information**:
- PR number and URL
- PR title
- Full prompt text from body
- Outcome category (Merged/Closed/Open)
- Outcome category (Merged/Closed/Open) - requires additional `gh pr view` calls
- Creation date
- Merge/close date (if applicable)
- Merge/close date (if applicable) - use `gh pr view <number> --json mergedAt,closedAt` to get these

### Phase 3: Analyze Prompt Patterns

Expand Down
Loading