Extract `sanitizeWorkflowName` to dedicated helper module #3144

Copilot · 2025-11-04T15:09:22Z

Original prompt

This section details on the original issue you should resolve

<issue_title>[task] Extract sanitizeWorkflowName to dedicated helper file</issue_title>
<issue_description>## Objective
Extract the sanitizeWorkflowName function from pkg/workflow/js/parse_firewall_logs.cjs to its own dedicated helper file.

Context

The sanitizeWorkflowName function in parse_firewall_logs.cjs is a utility that could be reused. Following the pattern of "1 javascript helper per file so that they can be imported one by one", this should be extracted to its own module. Part of issue #3119.

Approach

Create new file: pkg/workflow/js/sanitize_workflow_name.cjs

Move the sanitizeWorkflowName function to the new file

Export the function as a CommonJS module: module.exports = { sanitizeWorkflowName };

Update pkg/workflow/js/parse_firewall_logs.cjs to import: const { sanitizeWorkflowName } = require('./sanitize_workflow_name.cjs');

Remove the function definition from parse_firewall_logs.cjs

Files to Modify

Create: pkg/workflow/js/sanitize_workflow_name.cjs (new helper file)

Update: pkg/workflow/js/parse_firewall_logs.cjs (import and remove definition)

Acceptance Criteria

New helper file sanitize_workflow_name.cjs contains the function

Function is properly exported as CommonJS module

parse_firewall_logs.cjs imports from the new helper

Function definition removed from parse_firewall_logs.cjs

Existing tests pass (no functionality broken)

Code follows the pattern: 1 helper per file for granular imports
Related to [refactor] 🔧 Semantic Function Clustering Analysis: Refactoring Opportunities #3119

AI generated by Plan Command for #3119</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes [task] Extract sanitizeWorkflowName to dedicated helper file #3134

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

- Created pkg/workflow/js/sanitize_workflow_name.cjs with the function - Updated parse_firewall_logs.cjs to import from new helper - Removed function definition from parse_firewall_logs.cjs - Updated parse_firewall_logs.test.cjs to remove sanitizeWorkflowName test - Created sanitize_workflow_name.test.cjs with comprehensive tests - All tests passing (655 tests, 34 test files) - TypeScript typecheck passing - Code formatted with prettier Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull Request Overview

This PR extracts the sanitizeWorkflowName function from parse_firewall_logs.cjs into its own dedicated module with comprehensive test coverage. This refactoring improves code organization and reusability.

Moved sanitizeWorkflowName function to a new standalone module sanitize_workflow_name.cjs
Created comprehensive test suite for the extracted function
Updated parse_firewall_logs.cjs to import the function instead of defining it locally

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
`pkg/workflow/js/sanitize_workflow_name.cjs`	New module containing the extracted `sanitizeWorkflowName` function
`pkg/workflow/js/sanitize_workflow_name.test.cjs`	New comprehensive test suite for `sanitizeWorkflowName`
`pkg/workflow/js/parse_firewall_logs.cjs`	Removed `sanitizeWorkflowName` function and its export, added import from new module
`pkg/workflow/js/parse_firewall_logs.test.cjs`	Removed test for `sanitizeWorkflowName` and cleanup of test setup code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pkg/workflow/js/sanitize_workflow_name.test.cjs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

pelikhan · 2025-11-04T15:35:35Z

@copilot merge main and recompile

…ize-workflow-name

- Merged latest changes from main branch - Recompiled all workflow lock files - All unit tests passing (Go + JavaScript) - Lock files updated to reflect latest changes Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-11-04T15:42:23Z

@copilot merge main and recompile

Merged main and recompiled all workflows in commit 651480d. All tests passing.

pelikhan · 2025-11-04T15:44:35Z

@copilot the require is not properly inlined by the bundled. Update compiler to embed new cjs file and bundle properly

- Added embed directive for sanitize_workflow_name.cjs - Registered sanitize_workflow_name.cjs in GetJavaScriptSources() - Converted parse_firewall_logs.cjs to use bundling pattern - Added getParseFirewallLogsScript() with lazy bundling - Updated GetLogParserScript() to use bundled version - Verified bundler properly inlines sanitize_workflow_name function - All tests passing (Go + JavaScript) - Recompiled all workflow lock files Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-11-04T15:55:24Z

@copilot the require is not properly inlined by the bundled. Update compiler to embed new cjs file and bundle properly

Updated compiler to properly bundle sanitize_workflow_name.cjs in commit e4ff745. The bundler now:

Embeds sanitize_workflow_name.cjs via go:embed directive
Registers it in GetJavaScriptSources() for bundling
Converts parse_firewall_logs.cjs to use lazy bundling pattern
Inlines the require() call and removes module.exports

Verified bundler correctly inlines the function and removes exports.

pelikhan · 2025-11-04T15:58:50Z

@copilot merge main

…ize-workflow-name # Conflicts: # .github/workflows/smoke-copilot.firewall.lock.yml

Copilot · 2025-11-04T16:05:09Z

@copilot merge main

Merged main in commit 398e11b. Resolved conflict with smoke-copilot.firewall.lock.yml (accepted deletion). All tests passing.

Initial plan

b926d56

Copilot AI assigned Copilot and pelikhan Nov 4, 2025

Copilot started work on behalf of pelikhan November 4, 2025 15:09 View session

Copilot AI changed the title ~~[WIP] Extract sanitizeWorkflowName to dedicated helper file~~ Extract sanitizeWorkflowName to dedicated helper module Nov 4, 2025

Copilot AI requested a review from pelikhan November 4, 2025 15:20

Copilot finished work on behalf of pelikhan November 4, 2025 15:20

pelikhan approved these changes Nov 4, 2025

View reviewed changes

pelikhan marked this pull request as ready for review November 4, 2025 15:26

Copilot AI review requested due to automatic review settings November 4, 2025 15:26

Copilot AI reviewed Nov 4, 2025

View reviewed changes

pkg/workflow/js/sanitize_workflow_name.test.cjs Outdated Show resolved Hide resolved

Update sanitize_workflow_name.test.cjs

82a07ce

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started work on behalf of pelikhan November 4, 2025 15:36 View session

Copilot AI and others added 2 commits November 4, 2025 15:40

Merge remote-tracking branch 'origin/main' into copilot/extract-sanit…

db7a8e7

…ize-workflow-name

Merge main and recompile workflows

651480d

- Merged latest changes from main branch - Recompiled all workflow lock files - All unit tests passing (Go + JavaScript) - Lock files updated to reflect latest changes Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI requested a review from pelikhan November 4, 2025 15:44

Copilot finished work on behalf of pelikhan November 4, 2025 15:44

Copilot started work on behalf of pelikhan November 4, 2025 15:45 View session

Copilot finished work on behalf of pelikhan November 4, 2025 15:57

pelikhan approved these changes Nov 4, 2025

View reviewed changes

Copilot started work on behalf of pelikhan November 4, 2025 15:59 View session

Merge remote-tracking branch 'origin/main' into copilot/extract-sanit…

398e11b

…ize-workflow-name # Conflicts: # .github/workflows/smoke-copilot.firewall.lock.yml

pelikhan merged commit 7009272 into main Nov 4, 2025
3 checks passed

pelikhan deleted the copilot/extract-sanitize-workflow-name branch November 4, 2025 16:05

Copilot AI requested a review from pelikhan November 4, 2025 16:05

Copilot finished work on behalf of pelikhan November 4, 2025 16:05

Copilot AI mentioned this pull request Nov 4, 2025

Merge main branch and recompile workflows #3160

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extract `sanitizeWorkflowName` to dedicated helper module #3144

Extract `sanitizeWorkflowName` to dedicated helper module #3144

Uh oh!

Copilot AI commented Nov 4, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

pelikhan commented Nov 4, 2025

Uh oh!

Copilot AI commented Nov 4, 2025

Uh oh!

pelikhan commented Nov 4, 2025

Uh oh!

Copilot AI commented Nov 4, 2025

Uh oh!

pelikhan commented Nov 4, 2025

Uh oh!

Copilot AI commented Nov 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Extract sanitizeWorkflowName to dedicated helper module #3144

Extract sanitizeWorkflowName to dedicated helper module #3144

Uh oh!

Conversation

Copilot AI commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Approach

Files to Modify

Acceptance Criteria

Comments on the Issue (you are @copilot in this section)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

pelikhan commented Nov 4, 2025

Uh oh!

Copilot AI commented Nov 4, 2025

Uh oh!

pelikhan commented Nov 4, 2025

Uh oh!

Copilot AI commented Nov 4, 2025

Uh oh!

pelikhan commented Nov 4, 2025

Uh oh!

Copilot AI commented Nov 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Extract `sanitizeWorkflowName` to dedicated helper module #3144

Extract `sanitizeWorkflowName` to dedicated helper module #3144

Copilot AI commented Nov 4, 2025 •

edited

Loading