Rename ValidatePermissions to ValidateIncludedPermissions in imports.go

[Copilot]

Two different ValidatePermissions functions existed with incompatible signatures, causing navigation confusion:

• pkg/workflow/imports.go:161 - Compiler method validating permissions from imported files
• pkg/workflow/permissions_validator.go:92 - Standalone function validating permissions against GitHub MCP toolsets

Changes

• Renamed Compiler.ValidatePermissions() → ValidateIncludedPermissions() in pkg/workflow/imports.go
• Updated caller in pkg/workflow/compiler.go:676
• Updated test function TestValidatePermissions → TestValidateIncludedPermissions
• Added cross-reference documentation to both functions explaining distinct purposes

Usage

// General permission validation against GitHub MCP toolsets
result := ValidatePermissions(permissions, githubTool)

// Permission validation for imported/included workflow files
err := compiler.ValidateIncludedPermissions(topPermissionsYAML, importedPermissionsJSON)

The renamed function clarifies its specific role in the imports workflow, while the standalone validator remains the canonical general-purpose validator.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[task] Resolve ValidatePermissions naming conflict between imports.go and permissions_validator.go</issue_title>
<issue_description>## Objective
Rename conflicting ValidatePermissions functions to clarify their distinct purposes and prevent confusion.

Context

Two different ValidatePermissions functions exist with different signatures:

• pkg/workflow/imports.go:347 - Part of Compiler, validates permissions from included files
• pkg/workflow/permissions_validator.go:92 - Standalone function using PermissionsValidator

This creates confusion when calling validation functions and makes the codebase harder to navigate.

Part of issue #3435.

Approach

1. Analyze function purposes

Review both functions to understand their specific responsibilities:

• imports.go version: Validates permissions when merging included files
• permissions_validator.go version: General permission validation

2. Rename for clarity

Rename the imports.go function to ValidateIncludedPermissions to reflect its specific purpose of validating permissions from included files.

Keep the permissions_validator.go function as ValidatePermissions since it's the general-purpose validator.

3. Update all callers

• Find all references to the renamed function
• Update function calls to use the new name
• Update any related documentation or comments

4. Add documentation

Add clear comments explaining:

• When to use ValidatePermissions (general validation)
• When to use ValidateIncludedPermissions (when merging includes)

Files to Modify

• pkg/workflow/imports.go - Rename function from ValidatePermissions to ValidateIncludedPermissions
• All files that call imports.go's ValidatePermissions function
• Add documentation comments to both functions

Acceptance Criteria

• Function in imports.go renamed to ValidateIncludedPermissions
• All callers of the renamed function updated
• Both functions have clear documentation explaining their distinct purposes
• All tests pass (make test-unit)
• No confusion between the two validation functions
• Code builds successfully
  Related to [refactor] 🔧 Semantic Function Clustering Analysis - Code Organization Opportunities #3435

AI generated by Plan Command for #3435</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes [task] Resolve ValidatePermissions naming conflict between imports.go and permissions_validator.go #3537

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull Request Overview

This PR renames a function to better distinguish between two different permission validation use cases. The function ValidatePermissions in imports.go has been renamed to ValidateIncludedPermissions to clarify that it specifically validates permissions when merging included/imported workflow files, distinguishing it from the general-purpose ValidatePermissions function in permissions_validator.go that validates permissions against GitHub MCP toolsets.

Key changes:

• Renamed Compiler.ValidatePermissions() to Compiler.ValidateIncludedPermissions() in imports.go
• Updated all call sites to use the new function name
• Added comprehensive documentation explaining when to use each validation function

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
pkg/workflow/imports.go	Renamed method from ValidatePermissions to ValidateIncludedPermissions and enhanced documentation to clarify its specific use case for validating imported workflow permissions
pkg/workflow/permissions_validator.go	Enhanced documentation for ValidatePermissions function to clarify it's for general MCP toolset validation and distinguish it from the renamed function
pkg/workflow/compiler.go	Updated function call from ValidatePermissions to ValidateIncludedPermissions
pkg/workflow/permissions_import_test.go	Updated test function name and all error messages to reflect the renamed function

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.