Add assign-to-user safe output type by Copilot · Pull Request #5340 · github/gh-aw

Copilot · 2025-12-02T23:47:13Z

Original prompt

add-safe-output-type

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Changeset

Type: patch
Description: Add assign-to-user safe output type with schema, Go structs, job builder, JavaScript runner script, tests, and documentation.

AI generated by Changeset Generator

Smoke Test Summary

Timestamp: 2025-12-03T00:57:55Z
Status: PASS
All Copilot engine tests passed (GitHub MCP, file I/O, bash, Playwright)

AI generated by Smoke Copilot No Firewall

- Add JSON schema definition for assign-to-user in main_workflow_schema.json - Add AssignToUserConfig struct and parsing logic - Create pkg/workflow/assign_to_user.go for job builder - Create pkg/workflow/js/assign_to_user.cjs JavaScript implementation - Add assign_to_user tool to safe_outputs_tools.json - Register script and embed directive in scripts.go and js.go - Add to generateFilteredToolsJSON(), generateSafeOutputsConfig(), HasSafeOutputsEnabled() - Add to compiler_jobs.go for job building - Add to safe_output_validation_config.go for validation - Update tests in safe_outputs_tools_test.go and safe_output_validation_config_test.go - Update documentation in docs/src/content/docs/reference/safe-outputs.md Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>

Change from 0 to 1 to match documented default behavior. Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>

Reduce code duplication and improve consistency with other similar parsing functions. Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>

pelikhan

@copilot add a test agentic workflow (with the other test files) that uses this safe output type.

This adds a test agentic workflow that exercises the new assign-to-user safe output type. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-12-03T00:52:00Z

@copilot add a test agentic workflow (with the other test files) that uses this safe output type.

Added pkg/cli/workflows/test-assign-to-user.md in commit 996a78a.

github-actions · 2025-12-03T00:56:01Z

🔮 The ancient spirits stir... Smoke Codex awakens to divine this pull request...

github-actions · 2025-12-03T00:56:01Z

💥 WHOOSH! Smoke Claude springs into action on this pull request! [Panel 1 begins...]

github-actions · 2025-12-03T00:56:01Z

🤖 SYSTEM_INIT: Smoke Copilot No Firewall ACTIVATED. PROCESSING pull request. ALL SUBSYSTEMS ONLINE.

github-actions · 2025-12-03T00:56:02Z

📰 BREAKING: Smoke Copilot Playwright is now investigating this pull request. Sources say the story is developing...

github-actions · 2025-12-03T00:56:02Z

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

github-actions · 2025-12-03T00:56:02Z

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

github-actions · 2025-12-03T00:58:27Z

Smoke Test Results

Last 2 Merged PRs:

Convert embedded custom agents to prompt file format #5337: Convert embedded custom agents to prompt file format
refactor: rename to firewall-escape.md, add 80% novelty requirement, and increase timeout #4789: refactor: rename to firewall-escape.md, add 80% novelty requirement, and increase timeout

Test Results:

✅ GitHub MCP Testing
✅ File Writing Testing
✅ Bash Tool Testing

Status: PASS

📰 BREAKING: Report filed by Smoke Copilot fer issue #5340 🗺️

github-actions · 2025-12-03T00:59:03Z

Smoke Test: Claude Engine Validation (Run 19878593872)

Recent PRs:

Migrate workflow commands (run, status, logs, audit) to RunE #5329: Migrate workflow commands to RunE
feat: enable firewall on claude and remove hooks" #4792: Enable firewall on claude

Test Results:
✅ GitHub MCP: Retrieved last 2 merged PRs
✅ File Writing: Created /tmp/gh-aw/agent/smoke-test-claude-19878593872.txt
✅ Bash Tool: Verified file contents
✅ Playwright MCP: Navigated to GitHub, title contains "GitHub"

Status: PASS

💥 [THE END] — Illustrated by Smoke Claude fer issue #5340 🗺️

github-actions · 2025-12-03T00:59:47Z

Convert embedded custom agents to prompt file format
Migrate workflow commands (run, status, logs, audit) to RunE
GitHub MCP testing: ✅
File writing testing: ✅
Bash tool testing: ✅
Playwright MCP testing: ✅
Overall status: PASS

🔮 The oracle has spoken through Smoke Codex fer issue #5340 🗺️

pelikhan · 2025-12-03T01:02:59Z

@copilot update dev.md to assign an issue to mrjf on workflow dispatch

Changes the dev workflow from using assign-to-agent (Copilot) to assign-to-user (mrjf) for issue assignment. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-12-03T01:09:38Z

@copilot update dev.md to assign an issue to mrjf on workflow dispatch

Updated .github/workflows/dev.md to use assign-to-user with mrjf as the allowed assignee in commit 4e070e1.

github-actions · 2025-12-03T04:19:01Z

✅ Dev Hawk Report - Success

Workflow Run: #3030

Status: ✅ success
Commit: 4e070e1
Branch: copilot/add-safe-output-type
Duration: 1m 49s
Triggered by: @pelikhan

Summary

The Dev workflow completed successfully! 🎉

This run validated the changes from commit 4e070e1 which updates the dev.md workflow to use assign-to-user for mrjf on workflow dispatch.

🦅 Automated report by Dev Hawk

🦅 Observed from above by Dev Hawk

pelikhan · 2025-12-03T04:22:19Z

The assign to user safe output job was not invoked in this run https://github.com/githubnext/gh-aw/actions/runs/19882156439/job/56982274706#step:32:1. Investigate why.

pelikhan · 2025-12-03T04:27:33Z

@copilot execute comment above

The assign_to_user job requires `target: "*"` when triggered via workflow_dispatch since there's no issue context. Without this, the job condition included `(github.event.issue.number)` which evaluates to falsy on workflow_dispatch events. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-12-03T04:36:39Z

The assign to user safe output job was not invoked in this run https://github.com/githubnext/gh-aw/actions/runs/19882156439/job/56982274706#step:32:1. Investigate why.

The assign_to_user job was skipped because the job condition included (github.event.issue.number) which evaluates to falsy on workflow_dispatch events (no issue context).

Fixed by adding target: "*" to the assign-to-user config in dev.md, which tells the compiler that the issue number comes from the agent's output rather than the event context. This removes the issue context requirement from the job condition.

Fixed in c28b405.

pelikhan · 2025-12-03T04:43:06Z

@copilot handle the case where target="*" in the javascript. See failed job at https://github.com/githubnext/gh-aw/actions/runs/19882573193/job/56983535857

github-actions · 2025-12-03T04:43:13Z

⚠️ Dev Hawk Report - Failure Analysis

Workflow Run: #3031

Status: failure
Commit: c28b405
Duration: ~104 seconds
Failed Job: assign_to_user

Root Cause Analysis

The assign-to-user job failed during target resolution when processing a safe output with target: "*". The error indicates a mismatch between the configuration and the runtime context:

Error Message:

Target is "*" but no item_number specified in user assignment item

Issue Details

When target: "*" is configured (which means "apply to any issue/PR"), the safe output processing expects the agent's output to include an item_number field to specify which issue to target. However, when triggered via workflow_dispatch (manual trigger), there's no associated issue context, and the agent output doesn't contain an item_number.

The Configuration:

target: "*" was added to make the job work with workflow_dispatch
This allows the job to run without requiring github.event.issue.number
But the JavaScript implementation expects item_number in the agent output when target is "*"

What happened:

Workflow was triggered via workflow_dispatch (no issue context)
Job ran with target: "*" configuration
Agent produced output without item_number field
Target resolution failed because "*" requires explicit item_number

Recommended Actions

Choose one of the following approaches:

Option 1: Make item_number optional when there's a current issue context
- Update the target resolution logic in assign_to_user.cjs to fall back to context.issue.number when item_number is not provided
- This would match the behavior of other safe outputs
Option 2: Skip the job on workflow_dispatch when there's no issue
- Update the job condition to include github.event.issue.number check
- Remove target: "*" since it won't work without an issue context anyway
Option 3: Make the target resolution more flexible
- When target: "*" and no item_number is provided, check if there's a current issue/PR from the workflow trigger context
- Use that as the implicit target if available

Context

This is a test of the new assign-to-user safe output feature. The fix in commit c28b405 attempted to make the job work with workflow_dispatch by adding target: "*", but this exposed a gap in how the target resolution handles the wildcard case without an explicit item number.

🦅 Observed from above by Dev Hawk

pelikhan · 2025-12-03T04:47:44Z

@copilot update dev.md to pick an issue if none is specified in context.

When target="*", the resolveTarget function now checks for item.issue_number in addition to item.item_number and item.pull_request_number. This fixes assign_to_user failing when the agent output uses the standard issue_number field. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-12-03T04:50:34Z

@copilot handle the case where target="*" in the javascript. See failed job at https://github.com/githubnext/gh-aw/actions/runs/19882573193/job/56983535857

The resolveTarget function in safe_output_helpers.cjs was only checking for item_number and pull_request_number when target="*", but the agent output uses issue_number.

Fixed by adding issue_number to the list of fields checked when target="*" and supportsPR is true.

Fixed in b90b51a.

Changed from searching for specific "[deps]" issues to searching for any open issue that isn't already assigned to mrjf. This makes the workflow more general and useful for testing assign-to-user. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-12-03T04:56:29Z

@copilot update dev.md to pick an issue if none is specified in context.

Updated dev.md to search for any open unassigned issue in the repository instead of only "[deps]" issues. The workflow now finds the first open issue not already assigned to mrjf.

Fixed in 5835830.

…gnment in safe_output_helpers

github-actions · 2025-12-03T05:28:50Z

✅ Dev Hawk Report - Success

Workflow Run: #3032

Status: ✅ success
Commit: f1161df
Duration: ~1m 48s
Branch: copilot/add-safe-output-type

The Dev workflow completed successfully! 🎉

Summary

The workflow executed the following commit:

Fix: Update setup-node action version and streamline numberField assignment in safe_output_helpers

All checks passed without issues.

🦅 Observed from above by Dev Hawk

Initial plan

98a55e6

Copilot AI assigned Copilot and mrjf Dec 2, 2025

Copilot started work on behalf of mrjf December 2, 2025 23:47 View session

Copilot AI and others added 3 commits December 3, 2025 00:15

Fix default max value in parseBaseSafeOutputConfig call

5f70a5b

Change from 0 to 1 to match documented default behavior. Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>

Refactor parseAssignToUserConfig to use ParseListJobConfig

3d7565e

Reduce code duplication and improve consistency with other similar parsing functions. Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add safe output type for improved data handling~~ Add assign-to-user safe output type Dec 3, 2025

Copilot AI requested a review from mrjf December 3, 2025 00:28

Copilot finished work on behalf of mrjf December 3, 2025 00:28

pelikhan marked this pull request as ready for review December 3, 2025 00:44

pelikhan reviewed Dec 3, 2025

View reviewed changes

Copilot started work on behalf of pelikhan December 3, 2025 00:46 View session

mrjf mentioned this pull request Dec 3, 2025

Add safe output for assigning users to issues #5333

Closed

Add test-assign-to-user.md workflow for assign_to_user safe output

996a78a

This adds a test agentic workflow that exercises the new assign-to-user safe output type. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI requested a review from pelikhan December 3, 2025 00:53

Copilot finished work on behalf of pelikhan December 3, 2025 00:53

pelikhan added the smoke label Dec 3, 2025

github-actions bot added the smoke-copilot label Dec 3, 2025

Add changeset [skip-ci]

1ef0994

github-actions bot added the smoke-claude label Dec 3, 2025

github-actions bot added the smoke-codex label Dec 3, 2025

Copilot started work on behalf of pelikhan December 3, 2025 01:03 View session

Update dev.md to use assign-to-user for mrjf on workflow dispatch

4e070e1

Changes the dev workflow from using assign-to-agent (Copilot) to assign-to-user (mrjf) for issue assignment. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan December 3, 2025 01:11

Copilot started work on behalf of pelikhan December 3, 2025 04:28 View session

Copilot finished work on behalf of pelikhan December 3, 2025 04:38

Copilot started work on behalf of pelikhan December 3, 2025 04:43 View session

Copilot finished work on behalf of pelikhan December 3, 2025 04:52

Copilot started work on behalf of pelikhan December 3, 2025 04:52 View session

Copilot finished work on behalf of pelikhan December 3, 2025 04:58

pelikhan added 2 commits December 2, 2025 21:21

Merge branch 'main' into copilot/add-safe-output-type

6a2e077

Fix: Update setup-node action version and streamline numberField assi…

f1161df

…gnment in safe_output_helpers

pelikhan merged commit 867ae42 into main Dec 3, 2025
24 of 25 checks passed

pelikhan deleted the copilot/add-safe-output-type branch December 3, 2025 05:27

Conversation

Copilot AI commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset

Smoke Test Summary

Uh oh!

pelikhan left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025 • edited by agentic-workflows-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 3, 2025

Smoke Test Results

Uh oh!

github-actions bot commented Dec 3, 2025

Smoke Test: Claude Engine Validation (Run 19878593872)

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

pelikhan commented Dec 3, 2025

Uh oh!

Copilot AI commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

✅ Dev Hawk Report - Success

Summary

Uh oh!

pelikhan commented Dec 3, 2025

Uh oh!

pelikhan commented Dec 3, 2025

Uh oh!

Copilot AI commented Dec 3, 2025

Uh oh!

pelikhan commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

⚠️ Dev Hawk Report - Failure Analysis

Root Cause Analysis

Issue Details

Recommended Actions

Context

Uh oh!

pelikhan commented Dec 3, 2025

Uh oh!

Copilot AI commented Dec 3, 2025

Uh oh!

Copilot AI commented Dec 3, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 3, 2025

✅ Dev Hawk Report - Success

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Dec 2, 2025 •

edited

Loading

github-actions bot commented Dec 3, 2025 •

edited by agentic-workflows-dev bot

Loading