Skip to content

[security-fix] Security Fix: Remove sensitive key names from secrets validation log messages (Alert #71) #7224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Dec 22, 2025
Merged

[security-fix] Security Fix: Remove sensitive key names from secrets validation log messages (Alert #71) #7224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/workflow/secrets_validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ var secretsExpressionPattern = regexp.MustCompile(`^\$\{\{\s*secrets\.[A-Za-z_][
// Returns an error if the value is not in the format: ${{ secrets.NAME }} or ${{ secrets.NAME || secrets.NAME2 }}
func validateSecretsExpression(key, value string) error {
if !secretsExpressionPattern.MatchString(value) {
secretsValidationLog.Printf("Invalid secret expression for key %s", key)
secretsValidationLog.Printf("Invalid secret expression detected")
return fmt.Errorf("jobs.secrets.%s must be a GitHub Actions expression with secrets reference (e.g., '${{ secrets.MY_SECRET }}' or '${{ secrets.SECRET1 || secrets.SECRET2 }}')", key)
}
secretsValidationLog.Printf("Valid secret expression for key %s", key)
secretsValidationLog.Printf("Valid secret expression validated")
return nil
}