Skip to content

Comments

Fix hourly CI cleaner workflow build configuration#7261

Closed
Copilot wants to merge 2 commits intoci-cleaner/architecture-issue-20251222-140940-4468a3242518d3eefrom
copilot/sub-pr-7256
Closed

Fix hourly CI cleaner workflow build configuration#7261
Copilot wants to merge 2 commits intoci-cleaner/architecture-issue-20251222-140940-4468a3242518d3eefrom
copilot/sub-pr-7256

Conversation

Copy link
Contributor

Copilot AI commented Dec 22, 2025

The hourly CI cleaner workflow had incorrect build setup steps that didn't align with the working pattern in ci.yml.

Changes:

  • Removed manual make installation (already available in GitHub Actions runners)
  • Pinned setup actions to specific commit SHAs matching ci.yml:
    • actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f (v6.1.0)
    • actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c (v6.1.0)
  • Replaced make deps-dev (installs linter tooling) with make build (builds the binary)
  • Reordered setup: Node.js → Go → npm install → build
  • Removed unnecessary troubleshooting documentation file

The workflow now follows the proven ci.yml build job pattern, ensuring build tools are available to the agent when it runs make fmt, make lint, make test-unit, and make recompile.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI self-assigned this Dec 22, 2025
- Remove docs/troubleshooting/ci-cleaner-architecture.md as requested
- Fix hourly-ci-cleaner.md workflow by aligning with ci.yml build job pattern:
  - Remove manual 'make install' step (make is already available)
  - Pin GitHub Actions to specific SHAs per security best practices
  - Replace 'make deps-dev' with 'make build' to build the binary
  - Reorder Node.js setup before Go setup to match ci.yml pattern
- Workflow now properly sets up the build environment before agent execution

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix CI cleaner architecture limitation Fix hourly CI cleaner workflow build configuration Dec 22, 2025
Copilot AI requested a review from pelikhan December 22, 2025 15:05
@pelikhan pelikhan closed this Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants