Skip to content

Rewrite lock-issue script to export main and call via require() #7437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 4 commits into from
Dec 23, 2025
Merged

Rewrite lock-issue script to export main and call via require() #7437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebc4ff9
Initial plan
Copilot Dec 23, 2025
5fad1e4
Initial plan for rewriting lock-issue script
Copilot Dec 23, 2025
fbbf6f8
Rewrite lock-issue script to export main and call from require
Copilot Dec 23, 2025
471705e
Final validation completed - all lock_for_agent tests passing
Copilot Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ai-moderator.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion .github/workflows/campaign-generator.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion .github/workflows/workflow-generator.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions actions/setup/js/add_comment.cjs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion actions/setup/js/lock-issue.cjs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion actions/setup/js/noop.cjs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/workflow/compiler_activation_jobs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,8 @@ func (c *Compiler) buildActivationJob(data *WorkflowData, preActivationJobCreate
steps = append(steps, " global.context = context;\n")
steps = append(steps, " global.exec = exec;\n")
steps = append(steps, " global.io = io;\n")
steps = append(steps, " require('"+SetupActionDestination+"/lock-issue.cjs');\n")
steps = append(steps, " const { main } = require('"+SetupActionDestination+"/lock-issue.cjs');\n")
steps = append(steps, " await main();\n")
} else {
// Add the lock-issue script
formattedScript := FormatJavaScriptForYAML(lockIssueScript)
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/js/lock-issue.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,4 @@ async function main() {
}
}

await main();
module.exports = { main };
8 changes: 4 additions & 4 deletions pkg/workflow/lock_for_agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ Test workflow with lock-for-agent enabled.
"Lock issue for agent workflow",
"Unlock issue after agent workflow",
"GH_AW_LOCK_FOR_AGENT: \"true\"",
"lockForAgent && (eventName === \"issues\" || eventName === \"issue_comment\")",
"This issue has been locked while the workflow is running",
"lock-issue.cjs", // Check for require() call to lock-issue script
"unlock-issue.cjs", // Check for require() call to unlock-issue script
}

for _, expected := range expectedStrings {
Expand Down Expand Up @@ -378,8 +378,8 @@ Test workflow with lock-for-agent enabled for issue_comment events.
"Lock issue for agent workflow",
"Unlock issue after agent workflow",
"GH_AW_LOCK_FOR_AGENT: \"true\"",
"lockForAgent && (eventName === \"issues\" || eventName === \"issue_comment\")",
"This issue has been locked while the workflow is running",
"lock-issue.cjs", // Check for require() call to lock-issue script
"unlock-issue.cjs", // Check for require() call to unlock-issue script
}

for _, expected := range expectedStrings {
Expand Down