Skip to content

fix timezone for stop time #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsyme merged 1 commit into from
Aug 15, 2025
Merged

fix timezone for stop time #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/workflow/compiler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ func (c *Compiler) parseWorkflowFile(markdownPath string) (*WorkflowData, error)

// Resolve relative stop-time to absolute time if needed
if workflowData.StopTime != "" {
resolvedStopTime, err := resolveStopTime(workflowData.StopTime, time.Now())
resolvedStopTime, err := resolveStopTime(workflowData.StopTime, time.Now().UTC())
if err != nil {
return nil, fmt.Errorf("invalid stop-time format: %w", err)
}
Expand Down
14 changes: 7 additions & 7 deletions pkg/workflow/time_delta.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,8 @@ func parseAbsoluteDateTime(dateTimeStr string) (string, error) {
// Try to parse with each format
for _, format := range formats {
if parsed, err := time.Parse(format, dateTimeStr); err == nil {
// Successfully parsed, return in standard format
return parsed.Format("2006-01-02 15:04:05"), nil
// Successfully parsed, convert to UTC and return in standard format
return parsed.UTC().Format("2006-01-02 15:04:05"), nil
}
}

Expand All @@ -207,8 +207,8 @@ func parseAbsoluteDateTime(dateTimeStr string) (string, error) {

for _, format := range formats {
if parsed, err := time.Parse(format, normalizedStr); err == nil {
// Successfully parsed, return in standard format
return parsed.Format("2006-01-02 15:04:05"), nil
// Successfully parsed, convert to UTC and return in standard format
return parsed.UTC().Format("2006-01-02 15:04:05"), nil
}
}

Expand All @@ -231,7 +231,7 @@ func parseAbsoluteDateTime(dateTimeStr string) (string, error) {

for _, format := range smartFormats {
if parsed, err := time.Parse(format, dateTimeStr); err == nil {
return parsed.Format("2006-01-02 15:04:05"), nil
return parsed.UTC().Format("2006-01-02 15:04:05"), nil
}
}

Expand All @@ -253,8 +253,8 @@ func resolveStopTime(stopTime string, compilationTime time.Time) (string, error)
return "", err
}

// Calculate absolute time
absoluteTime := compilationTime.Add(delta.toDuration())
// Calculate absolute time in UTC
absoluteTime := compilationTime.UTC().Add(delta.toDuration())

// Format in the expected format: "YYYY-MM-DD HH:MM:SS"
return absoluteTime.Format("2006-01-02 15:04:05"), nil
Expand Down