Skip to content

Eliminate engine field duplication in included_file_schema.json #7955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Dec 28, 2025
Merged

Eliminate engine field duplication in included_file_schema.json #7955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28f8af3
Initial plan
Copilot Dec 28, 2025
516e443
Fix engine field duplication by using $ref in included_file_schema.json
Copilot Dec 28, 2025
d4dbbd4
Complete: Fix engine field duplication in included_file_schema.json
Copilot Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,14 @@
"image": "mcr.microsoft.com/devcontainers/go:1-bookworm",
"customizations": {
"vscode": {
"extensions": ["golang.go", "GitHub.copilot-chat", "GitHub.copilot", "github.vscode-github-actions", "astro-build.astro-vscode", "DavidAnson.vscode-markdownlint"]
"extensions": [
"golang.go",
"GitHub.copilot-chat",
"GitHub.copilot",
"github.vscode-github-actions",
"astro-build.astro-vscode",
"DavidAnson.vscode-markdownlint"
]
},
"codespaces": {
"repositories": {
Expand Down
2 changes: 1 addition & 1 deletion actions/setup/js/create_issue.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ async function main() {
} else {
// It's a real issue number (may have # prefix)
const parentStr = String(createIssueItem.parent).trim();
const parentWithoutHash = parentStr.startsWith('#') ? parentStr.substring(1) : parentStr;
const parentWithoutHash = parentStr.startsWith("#") ? parentStr.substring(1) : parentStr;
effectiveParentIssueNumber = parseInt(parentWithoutHash, 10);
if (isNaN(effectiveParentIssueNumber)) {
core.warning(`Invalid parent value: ${createIssueItem.parent}`);
Expand Down
Loading
Loading