Fix lint:cjs to explicitly ignore package.json and package-lock.json#8001
Merged
pelikhan merged 5 commits intomain-9969beee31b5f93ffrom Dec 28, 2025
Merged
Conversation
Updated format:cjs and lint:cjs scripts in actions/setup/js/package.json to explicitly reference the root .prettierignore file using --ignore-path flag. This ensures package.json and package-lock.json files are consistently ignored during linting and formatting operations. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update lint:cjs to ignore package.json and package-lock.json
Fix lint:cjs to explicitly ignore package.json and package-lock.json
Dec 28, 2025
pelikhan
approved these changes
Dec 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lint:cjsnpm script was not consistently ignoringpackage.jsonandpackage-lock.jsonfiles across all contexts, causing CI failures when these files didn't match prettier's formatting expectations.Changes
--ignore-path ../../../.prettierignoreflag toformat:cjsandlint:cjsscripts inactions/setup/js/package.jsonContext
The root
.prettierignorealready contains patterns forpackage.jsonandpackage-lock.json, but prettier wasn't consistently applying them when run from theactions/setup/jssubdirectory. Other scripts in the samepackage.json(format:pkg-json,check:pkg-json) already use this explicit ignore-path pattern.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.