Fix check_membership test failures from missing error_helpers mock#8009
Merged
Fix check_membership test failures from missing error_helpers mock#8009
Conversation
…rror_helpers mock - Added missing `afterEach` import from vitest in check_membership.test.cjs - Updated mockRequire to handle error_helpers.cjs module required by check_permissions_utils.cjs - Fixed 15 failing tests in check_membership.test.cjs - All tests now pass except 3 pre-existing timeouts in safe_inputs_mcp_server.test.cjs Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix JavaScript tests for consistency and accuracy
Fix check_membership test failures from missing error_helpers mock
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #8000 added
require("./error_helpers.cjs")tocheck_permissions_utils.cjs, breaking tests that use custom module mocking vianew Function()evaluation.Changes
afterEachimport to vitest imports (was used but not imported)mockRequirefunction to handleerror_helpers.cjsmodulemockRequiretocheck_permissions_utils.cjsexecution contextFixes 15 failing tests in
check_membership.test.cjs.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.