Skip to content

[security-fix] Fix incorrect file permissions for MCP gateway config containing API keys #8024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Dec 29, 2025
Merged

[security-fix] Fix incorrect file permissions for MCP gateway config containing API keys #8024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/awmg/gateway.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,8 +440,8 @@ func rewriteMCPConfigForGateway(configPath string, config *MCPGatewayServiceConf
gatewayLog.Printf("Writing %d bytes to config file", len(data))
fmt.Fprintln(os.Stderr, console.FormatInfoMessage(fmt.Sprintf("Writing %d bytes to config file", len(data))))

// Write back to file
if err := os.WriteFile(configPath, data, 0644); err != nil {
// Write back to file with restricted permissions (0600) since it contains sensitive API keys
if err := os.WriteFile(configPath, data, 0600); err != nil {
gatewayLog.Printf("Failed to write rewritten config: %v", err)
fmt.Fprintln(os.Stderr, console.FormatErrorMessage(fmt.Sprintf("Failed to write rewritten config: %v", err)))
return fmt.Errorf("failed to write rewritten config: %w", err)
Expand Down