Fix jsweep workflow test failures and add snapshot schema support#8501
Merged
Fix jsweep workflow test failures and add snapshot schema support#8501
Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix jsweep workflow test failures and add snapshot schema support
Fix jsweep workflow test failures and add snapshot schema support
Jan 1, 2026
pelikhan
approved these changes
Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TestJSweepWorkflowConfigurationtest was failing due to missing validation phrases in the jsweep workflow. Additionally, the GitHub Actions workflow schema lacked support for thesnapshotkeyword.Changes
jsweep.md workflow validation phrases
GitHub Actions schema snapshot support
snapshotdefinition togithub-workflow.jsonsupporting both string and object syntax:{ "snapshot": "image-name" } // or { "snapshot": { "image-name": "custom-image", "version": "1.0.0" } }//go:embed, requiring binary rebuildWorkflow recompilation
Original prompt
This section details on the original issue you should resolve
<issue_title>[ca] Fix jsweep workflow test failures and add snapshot schema support</issue_title>
<issue_description>## Summary
This PR fixes CI test failures in the
pkg/workflowpackage by addressing missing validation phrases in the jsweep workflow and adding GitHub Actions snapshot feature support to the workflow schema.Changes Made
1. Fixed jsweep.md Workflow Test Requirements
The
TestJSweepWorkflowConfigurationtest was failing because the jsweep workflow was missing specific validation phrases. Added the following required text:These changes improve the workflow instructions by making validation requirements more explicit for contributors.
2. Added GitHub Actions Snapshot Support
Updated
pkg/workflow/schemas/github-workflow.jsonto add support for thesnapshotkeyword in job definitions. This enables custom image generation for GitHub Actions workflows:snapshotdefinition with support for both string and mapping syntaximage-nameand optionalversionpropertiesSince schema files are embedded using
//go:embeddirectives, rebuilt the binary to include the schema changes.3. Recompiled All Workflows
After schema changes, recompiled all workflow lock files to ensure they use the latest schema validation. Compiled 130 workflows successfully with expected warnings about:
Validation
✅ All Go tests passing:
✅ Code formatted with
go fmt✅ Workflows recompiled successfully
Notes
mcp-inspector.mdworkflow fails compilation due to an npm environment issue (Cannot find module '../lib/cli.js'). This is a pre-existing environment problem not introduced by these changes.CI Cleaner Report
Run: #333
Triggered by: Scheduled CI health check (twice daily at 6am/6pm UTC)
Issues Found:
pkg/workflowpackageIssues Fixed:
CI Status: ✅ All checks passing (except pre-existing npm environment issue in mcp-inspector.md)
To apply the patch locally:
Show patch preview (500 of 766 lines)