Add entrypoint and mounts fields to MCP server configs (breaking change)#9405
Merged
Add entrypoint and mounts fields to MCP server configs (breaking change)#9405
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
- Add entrypoint field to BaseMCPServerConfig for container entrypoint override - Add mounts field to BaseMCPServerConfig for container volume mounts - Update mcp_config_schema.json with new fields - Update parsing and validation logic to handle new fields - Transform entrypoint to docker --entrypoint flag - Transform mounts to docker -v flags Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
- Add entrypoint and mounts handling in parser.ParseMCPConfig - Transform entrypoint to docker --entrypoint flag - Transform mounts to docker -v flags with sorted order - Fix duplicate mounts extraction bug - Add comprehensive integration tests for entrypoint and mounts Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
- Add entrypoint and mounts fields to server configuration table - Mark gateway-level mounts as deprecated - Update configuration structure examples - Add new example A.2 showing per-server mounts and entrypoint - Renumber existing examples (A.3, A.4, A.5) - Add deprecation note for legacy gateway-level mounts Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
- Replace assert.Greater(x, 0) with assert.Positive(x) - All MCP-related tests passing Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix bugs in mcp gateway specification
Add entrypoint and mounts fields to MCP server configs
Jan 8, 2026
Contributor
|
@copilot do not care about backward compatibility. Match the spec as it is. Remove deprecated Gateway-level mounts marked deprecated |
- Remove Mounts field from MCPGatewayRuntimeConfig - Remove extraction logic for gateway-level mounts - Remove validation for gateway-level mounts - Remove docker command generation for gateway-level mounts - Delete mcp_gateway_config_test.go (tests for deprecated feature) - Remove TestGatewayMountsDeprecation test - Update documentation to remove deprecated mounts field - Remove deprecated A.3 example from spec - Update example file to show mounts on individual MCP servers - Update main_workflow_schema.json to remove gateway mounts - All MCP-related tests passing Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Removed all backward compatibility for gateway-level mounts. The Changes in commit 1460127:
The example file now demonstrates per-server mounts configuration instead of gateway-level mounts. |
Copilot
AI
changed the title
Add entrypoint and mounts fields to MCP server configs
Add entrypoint and mounts fields to MCP server configs (breaking change)
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP gateway spec had two bugs: missing optional
entrypointfield for container entrypoint overrides, andmountsconfigured at gateway level instead of per-server.Changes
Schema & Types
entrypoint(string) andmounts(array) fields toBaseMCPServerConfigmcp_config_schema.jsonwith new field definitions and validation patternsmountsfield fromMCPGatewayRuntimeConfig(breaking change)Parsing & Transformation
parser.ParseMCPConfigandworkflow.ParseMCPConfigFromMapto parse new fieldsentrypoint→docker run --entrypoint <value>mounts→docker run -v <source>:<dest>:<mode>(sorted for deterministic output)Breaking Change
mountsconfiguration is no longer supportedmountsconfigurationsandbox.mcp.mountstotools.<server-name>.mountsExample
Generates:
docker run --rm -i -v /host/cache:/cache:rw -v /host/data:/data:ro --entrypoint /custom/entrypoint.sh ghcr.io/org/server:latest --config /app/config.jsonOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.