fix issue with log-file arg #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue with the log-file CLI argument by ensuring that the flag is properly bound to viper.
- Removes the persistent pre-run binding from the server command.
- Adds the flag binding in the global initialization of persistent flags, ensuring it applies to all commands.
Files not reviewed (1)
- go.mod: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
SamMorrowDrums
approved these changes
Mar 14, 2025
manian0430
pushed a commit
to ChrisLally/github-mcp-server
that referenced
this pull request
Apr 12, 2025
fix issue with log-file arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Small fix to sure that the
--log-filecli argument is honoured.