add create_issue tool #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new tool called "create_issue" to enable creating issues in a GitHub repository using a comma-separated list for multi-value fields, along with associated tests and documentation updates.
- Added unit tests for parseCommaSeparatedList and createIssue functionality.
- Introduced the createIssue tool implementation and registered it in the server.
- Updated README documentation to include the new create_issue tool and its parameters.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/server_test.go | Added tests for parseCommaSeparatedList functionality. |
| pkg/github/issues_test.go | Added tests for createIssue tool covering success and failure cases. |
| README.md | Documentation updated for the new create_issue tool and its parameters. |
| pkg/github/issues.go | Added createIssue tool implementation using comma-separated list parsing. |
| pkg/github/server.go | Registered the createIssue tool and provided a local parseCommaSeparatedList. |
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
… juruen/create-issue
SamMorrowDrums
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
OK @juruen can you make an issue to re-visit the CSV style, and use proper JSON RPC arrays once it works?
manian0430
pushed a commit
to ChrisLally/github-mcp-server
that referenced
this pull request
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR adds a tool for creating an issue. We initially postponed this feature to wait for mcp-go to support arrays for describing arguments.
The library finally added support for arrays a few days ago. However, my first implementation, which used them, caused issues in VS Code.
Since VS Code is my main test platform, I decided to implement the array using a comma-separated list instead. We can revisit this decision once the issue is resolved.