Fix handling nil values for optional string array parameters, #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nil values should be equivalent to an empty string, currently we return an error but Claude passes nil for optional values.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of nil optional string array parameters by returning an empty array instead of an error.
- Updated the parameter parsing in pkg/github/server.go to treat nil values as an empty array.
- Added a test in pkg/github/issues_test.go to verify that nil inputs no longer cause failures.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/server.go | Added a nil case in the switch to return an empty array. |
| pkg/github/issues_test.go | Added a test case for nil assignees to validate behavior. |
manian0430
pushed a commit
to ChrisLally/github-mcp-server
that referenced
this pull request
Apr 12, 2025
…#194) * Fix handling nil values for optional string array parameters, nil values should be equivalent to an empty string, currently we return an error but Claude passes nil for optional values. * lint fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to use Claude for MCP tooling, any optional arrays it currently submits a nil value instead of an empty array which results in a returned error. This change adjusts that to return an empty array instead of an error for nil optional arrays.
Closes: #193