-
Notifications
You must be signed in to change notification settings - Fork 684
Add ability to view branches for a repo #141 #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @juruen, |
This looks great thank you, I just merged a PR that will require some small updates to this one: #195 |
Thanks for the heads-up! Just to clarify — could you please specify what small changes are needed following the merge of #195? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a little comment about making the test code more consistent with the existing code base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are almost there! There's just a few lint errors that need to be fixed: we need to make sure we use github.Ptr
and not the deprecated versions.
@juruen Update the code. Please review the PR . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aryasoni98 I almost forget, we need to update the README file with the new tool! 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we are just missing updating the README with the new tool
@juruen Update the README.md file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Thank you so much for your contribution!
Closes: #141