Skip to content

Allow passing through server options #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

Allow passing through server options #218

merged 2 commits into from
Apr 11, 2025

Conversation

omgitsads
Copy link
Member

Adds support the the underlying mcp-go ServerOptions so that hook functions can be attached to the server.

@Copilot Copilot AI review requested due to automatic review settings April 11, 2025 08:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR expands the server initialization to allow passing through additional server options so that hook functions can be attached to the server.

  • Adds a variadic parameter for extra server options.
  • Appends default options (resource capabilities and logging) before creating the MCP server.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Collaborator

@juruen juruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@SamMorrowDrums SamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@omgitsads omgitsads merged commit 3c18a34 into main Apr 11, 2025
16 checks passed
@omgitsads omgitsads deleted the add-server-opts branch April 11, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants