Skip to content

Document direct go install from GitHub #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rotemreiss
Copy link

Closes #302.

Documentation improvement to include direct installation from main branch without cloning the repo locally.

@rotemreiss rotemreiss requested a review from a team as a code owner April 17, 2025 11:59
Copy link
Collaborator

@williammartin williammartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Mixed feelings on this one. I appreciate having the ease of installation but it also hamstrings us if we want to use temporary replace directives in the go.mod (as opposed to hard forking a repository and updating all the paths).

This has caused issues before for the GitHub CLI.

Furthermore, our primary distribution mechanism are the releases and we do things like including build metadata:

RUN --mount=type=cache,target=/root/.cache/go-build CGO_ENABLED=0 go build -ldflags="-s -w -X main.version=${VERSION} -X main.commit=$(git rev-parse HEAD) -X main.date=$(date -u +%Y-%m-%dT%H:%M:%SZ)" \
. The more we can steer away from source building the better IMO. Of course, it should always still be an option locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Documentation for Direct Installation from GitHub
2 participants