Skip to content

add support for the create_pull_request_review_tool #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

juruen
Copy link
Collaborator

@juruen juruen commented Mar 24, 2025

Context

This PR adds support for the create_pull_request_review_tool.

Screenshot 2025-03-22 at 08 06 48

@Copilot Copilot AI review requested due to automatic review settings March 24, 2025 07:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a new tool "create_pull_request_review" that enables users to create a review on a pull request.

  • Introduces a new function createPullRequestReview in pkg/github/pullrequests.go.
  • Adds corresponding tests in pkg/github/pullrequests_test.go to verify behavior, including various input scenarios.
  • Updates the README.md documentation and registers the new tool in pkg/github/server.go.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
pkg/github/pullrequests.go Adds the createPullRequestReview function to construct and send review requests.
pkg/github/pullrequests_test.go Provides unit tests for various review creation scenarios.
README.md Documents the new create_pull_request_review tool and its input parameters.
pkg/github/server.go Registers the new tool with the server.
Comments suppressed due to low confidence (2)

README.md:129

  • The description contains a redundancy ('pull request review'). Consider changing it to 'Create a review on a pull request' for clarity.
- **create_pull_request_review** - Create a review on a pull request review

pkg/github/pullrequests.go:570

  • [nitpick] The use of the variable name 'body' here shadows the outer 'body' variable. Consider renaming it (e.g. 'commentBody') to improve clarity.
body, ok := commentMap["body"].(string)

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@juruen juruen force-pushed the juruen/update-issue-tool branch from 8e033fd to 5f5a0a5 Compare March 24, 2025 07:13
@juruen juruen force-pushed the juruen/create-pr-review-tool branch from a9681e0 to 7b3e15e Compare March 24, 2025 07:16
Base automatically changed from juruen/update-issue-tool to main March 24, 2025 12:25
@juruen juruen force-pushed the juruen/create-pr-review-tool branch from 7b3e15e to eec932c Compare March 24, 2025 12:48
@juruen juruen merged commit 7c772d2 into main Mar 24, 2025
4 checks passed
@juruen juruen deleted the juruen/create-pr-review-tool branch March 24, 2025 12:50
@juruen juruen restored the juruen/create-pr-review-tool branch March 24, 2025 12:53
manian0430 pushed a commit to ChrisLally/github-mcp-server that referenced this pull request Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants