fix: add required fields for OpenAI API #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the JSON schema definitions for OpenAI function calling API validation by adding the required "additionalProperties: false" and mandatory field arrays.
- Updated schema in repositories.go to enforce "path" and "content".
- Updated schema in pullrequests.go to enforce "path", "position", and "body".
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/repositories.go | Adds strict object schema validation with "additionalProperties" false and required fields for file properties. |
| pkg/github/pullrequests.go | Adds strict object schema validation with "additionalProperties" false and required fields for pull request review properties. |
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
SamMorrowDrums
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenAI function calling API requires that
additionalProperties: falseandrequired: []be set for arrays.