Update VS Code config JSON #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williammartin
requested review from
Copilot,
juruen and
SamMorrowDrums
and removed request for
Copilot
juruen
reviewed
Mar 27, 2025
| @@ -63,33 +63,37 @@ code-insiders | |||
|
|
|||
| Another way is to set the environment variable in your shell configuration file (e.g., `.bashrc`, `.zshrc`, etc.). | |||
|
|
|||
| Run **Preferences: Open User Settings (JSON)**, and create or append to the `mcp` setting: | |||
| Create a new file `.vscode/mcp.json` and provide this configuration: | |||
There was a problem hiding this comment.
Maybe we should remove the lines above that mention setting the token as env variable?
There was a problem hiding this comment.
I have no strong opinion on that. I didn't want to take away another option that might be in use. It does seem like this input approach should be elevated to a recommended approach at least?
juruen
approved these changes
Mar 27, 2025
SamMorrowDrums
approved these changes
Mar 27, 2025
manian0430
pushed a commit
to ChrisLally/github-mcp-server
that referenced
this pull request
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is now possible in VS Code to use
${input:github-pat}to indicate that the user should be prompted for an input. This helps keep credentials out of settings files.