Skip to content

chore: correct build arg syntax #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

chore: correct build arg syntax #75

merged 1 commit into from
Apr 3, 2025

Conversation

SamMorrowDrums
Copy link
Collaborator

No description provided.

@Copilot Copilot AI review requested due to automatic review settings April 3, 2025 11:20
@SamMorrowDrums SamMorrowDrums merged commit 367f8d4 into main Apr 3, 2025
15 checks passed
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to correct the build arg syntax used in the GitHub Actions workflow for Docker image publishing.

  • Changed the build-args configuration from a YAML mapping to a multiline string.

Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more

Comment on lines +83 to +84
build-args: |
VERSION=${{ github.ref_name }}
Copy link
Preview

Copilot AI Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new multiline string syntax changes the data type for build-args from a mapping to a string. Please verify that this syntax is supported by the Docker build action; otherwise, reverting to the original mapping format (using key-value pairs) might be necessary.

Suggested change
build-args: |
VERSION=${{ github.ref_name }}
build-args:
VERSION: ${{ github.ref_name }}

Copilot uses AI. Check for mistakes.

manian0430 pushed a commit to ChrisLally/github-mcp-server that referenced this pull request Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant