Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explanation for __pypackages__ #3242

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Conversation

mrg0029
Copy link
Contributor

@mrg0029 mrg0029 commented Nov 17, 2019

I was very confused by this. I'd heard of __pypackages__/ before but not pyflow.

A Google search for "pyflow" found several other projects with the same name (the project that Python.gitignore was referring to didn't show up until the 5th result for me). I only figured it out after finding this PR.

__pypackages__ comes from this PEP. It's currently in draft status i.e. the proposal hasn't been accepted and the directory is not used within CPython.

I didn't know if pyflow's use of __pypackages__ was in conflict with the PEP or if it's trying to be some kind of early implementation of it. I'm guessing the latter since it mentions the PEP
in its readme
.

tl;dr

The __pypackages__ directory isn't used by Python yet. But a somewhat obscure package is using the directory. It probably doesn't hurt to leave the ignore rule as is but a comment would be helpful.

@shiftkey
Copy link
Member

cc @thedrow who added this in #3205 - does this make sense to you?

@mrg0029
Copy link
Contributor Author

mrg0029 commented Nov 18, 2019

more research:

the big projects related to packaging and virtual environments

  • Poetry had an issue about __pypackages__ here. A lot of +1s but no replies.
  • Flit had zero matches when I searched its repo.
  • Searching the whole github.com/pypa org found just this one comment.

less-widely used projects

Copy link
Member

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrg0029 and @thedrow!

@shiftkey shiftkey merged commit db0ef78 into github:master Nov 18, 2019
tokuhira pushed a commit to tokuhira/gitignore that referenced this pull request Dec 16, 2019
r2pgl pushed a commit to r2pgl/gitignore that referenced this pull request Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants