Remove /bin from Eclipse IDE. #4611
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or how about create a new .gitignore file for Eclipse for PHP Developers? |
|
@Yousha, thats a good idea i think |
|
@Yousha Something we've done before is comment out the line, but then leave a descriptive message above it. How does that sound? |
|
Haven't seen any dialogue from the author after giving feedback. Closing for now. |
|
@wirecat What message? I couldn't find any message... |
|
@Yousha I was referring to #4611 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Many PHP/Composer tool packages include a bin folder for their functionality... This .gitignore entry ensures that these folders are ignored, preventing them from being tracked in version control. As a result, they will not be included in remote repositories.
So I THINK this entry should be removed., if Eclipse IDE used as editor for PHP projects.
Links to documentation supporting these rule changes
Projects/Packages that have bin folder:
https://github.com/squizlabs/PHP_CodeSniffer
https://github.com/overtrue/phplint
https://github.com/laravel/installer
etc...
If this is a new template
Merge and Approval Steps