feat: add non-mentioning links option #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willcl-ark
requested review from
jmeridth,
sutterj and
zkoppert
as code owners
|
Kindly requesting review from @Jeffrey-Luszcz as instructed :) |
jmeridth
reviewed
Sep 17, 2024
willcl-ark
force-pushed
the
non-mentioning-links
branch
from
b858db3 to
c03a0d7
Compare
jmeridth
approved these changes
Sep 19, 2024
7 tasks
jmeridth
added a commit
that referenced
this pull request
Sep 19, 2024
Closes #160 - [x] Adds the ability for users to designate custom report title and output files. - Defaults for each: - REPORT_TITLE: "Issue Metrics" - OUTPUT_FILE: "issue_metrics.md" if markdown and "issue_metrics.json" if json - [x] Update `.env-example` and include changes there and in docs we forgot in #370 Signed-off-by: jmeridth <jmeridth@gmail.com> Co-authored-by: Sebastian Spier <github@spier.hu> Co-authored-by: Zack Koppert <zkoppert@github.com>
jmeridth
added a commit
that referenced
this pull request
Sep 19, 2024
Closes #160 - [x] Adds the ability for users to designate custom report title and output files. - Defaults for each: - REPORT_TITLE: "Issue Metrics" - OUTPUT_FILE: "issue_metrics.md" if markdown and "issue_metrics.json" if json - [x] Update `.env-example` and include changes there and in docs we forgot in #370 Signed-off-by: jmeridth <jmeridth@gmail.com> Co-authored-by: Sebastian Spier <github@spier.hu> Co-authored-by: Zack Koppert <zkoppert@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Adds a new env var which allows you to specify non-mentioning links to the issues.
Non-mentioning links are possible using this workaround
Proposed Changes
The links still work as before, but they do not cause a notification in the desitnation repository, which helps reduce "spam" there.
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
fix,documentation,enhancement,infrastructure,maintenance, orbreaking