Remove hotkey functionality #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kate Higa <khiga8@github.com> Co-authored-by: Adrián Bolonio <bolonio85@gmail.com>
Co-authored-by: Kate Higa <khiga8@github.com> Co-authored-by: Adrián Bolonio <bolonio85@gmail.com>
Co-authored-by: Kate Higa <khiga8@github.com> Co-authored-by: Adrián Bolonio <bolonio85@gmail.com>
keithamus
approved these changes
Sep 15, 2021
This was referenced Sep 16, 2021
|
In case others stumble across this like I did... I don't think that using https://github.com/github/hotkey is the same as how the hotkeys used to work in this component. Main reason being this issue (github/hotkey#28), which points out how @github/hotkey is actually disabled on textareas (among other things). @koddsson or @keithamus correct me if I'm wrong, but that sort of defeats the purpose as far as the markdown toolbar goes, because you can't actually use the hotkeys while you're in the textarea (can't highlight text and hit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operating hotkeys in a markdown toolbar is out of scope for this web component. Consumers of this component that would like hotkey functionality should rather use a hotkey library such as
github/hotkey.Adding
data-hotkey="Meta+b"for the<md-bold>button should be the functional equivalent of the existing functionality and the same logic can be applied to the other buttons that have hotkeys enabled.