Update best-practices.md #718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated this file with missing spanish accents. Thank you!
|
Hi @angelitaooo I think the accents are there, just escaped. See https://opensource.guide/es/best-practices/ ... I don't know whether they need to be escaped or it would be more convenient to have unescaped text in the repo. Any thoughts on that (anyone)? The French translation seems to mostly (but not entirely) unescaped and seems to work. We should probably go one way or another and document in https://github.com/github/opensource.guide/blob/master/docs/translations.md Also, the front matter keys between |
mlinksva
added a commit
that referenced
this pull request
Oct 8, 2018
Accounting for changed location of translation index files #716 in and clarify field names should not be translated #718 (comment)
2 tasks
y777777
added a commit
to y777777/opensource.guide
that referenced
this pull request
Oct 18, 2018
* Fix form input for users with dark OS theme * Add/update translation for tamil language * Update for tamil translation * Fix the lint issues * Fix formatting (remove spaces before comma) * Fix failing tests for links (tamil translation) * Fix links not working (tamil translation) * Fix failing links and typos * Bump html-proofer from 3.9.1 to 3.9.2 Bumps [html-proofer](https://github.com/gjtorikian/html-proofer) from 3.9.1 to 3.9.2. - [Release notes](https://github.com/gjtorikian/html-proofer/releases) - [Commits](gjtorikian/html-proofer@v3.9.1...v3.9.2) Signed-off-by: dependabot[bot] <support@dependabot.com> * Prevent "time out" in script/html-proofer External link ... failed: got a time out (response code 301) * Bump primer-marketing from 6.2.4 to 6.2.5 Bumps [primer-marketing](https://github.com/primer/primer) from 6.2.4 to 6.2.5. - [Release notes](https://github.com/primer/primer/releases) - [Changelog](https://github.com/primer/primer/blob/master/CHANGELOG.md) - [Commits](https://github.com/primer/primer/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump github-pages from 188 to 189 Bumps [github-pages](https://github.com/github/pages-gem) from 188 to 189. - [Release notes](https://github.com/github/pages-gem/releases) - [Commits](github/pages-gem@v188...v189) Signed-off-by: dependabot[bot] <support@dependabot.com> * Add missing ToC entry * avoid redirect * add missing section link to translations * section links to match translations * missed one * ta/legal: fix broken link. * Bump github-pages from 189 to 191 Bumps [github-pages](https://github.com/github/pages-gem) from 189 to 191. - [Release notes](https://github.com/github/pages-gem/releases) - [Commits](github/pages-gem@v189...v191) Signed-off-by: dependabot[bot] <support@dependabot.com> * Update contributor funnel links. Rather than link to the slides from a talk I did let's link to the blog post explaining the concept a bit better. Also, let's update the image to a sharper and more emojid one. * [Security] Bump rubyzip from 1.2.1 to 1.2.2 Bumps [rubyzip](https://github.com/rubyzip/rubyzip) from 1.2.1 to 1.2.2. **This update includes security fixes.** - [Release notes](https://github.com/rubyzip/rubyzip/releases) - [Changelog](https://github.com/rubyzip/rubyzip/blob/master/Changelog.md) - [Commits](rubyzip/rubyzip@v1.2.1...v1.2.2) Signed-off-by: dependabot[bot] <support@dependabot.com> * Update hyperlinks * Update hyperlinks (fixup f0437ee) * Bump github-pages from 191 to 192 Bumps [github-pages](https://github.com/github/pages-gem) from 191 to 192. - [Release notes](https://github.com/github/pages-gem/releases) - [Commits](github/pages-gem@v191...v192) Signed-off-by: dependabot[bot] <support@dependabot.com> * Update best-practices.md Updated `procesimientos` since it's not a word :-), the right word could be `procesos`. Also, I added a `í` that was missing 👍 * fix link * Fix back to the index page link for non-English languages * Add keep-all to headings and heading-like elements * avoid redirect * Move index files into their own language directories * [Security] Bump nokogiri from 1.8.4 to 1.8.5 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.8.4 to 1.8.5. **This update includes security fixes.** - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.8.4...v1.8.5) Signed-off-by: dependabot[bot] <support@dependabot.com> * Fix Getting Paid page in Spanish language * Update es.yml I apply text that is still to be translated * Update translation instructions Accounting for changed location of translation index files github#716 in and clarify field names should not be translated github#718 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated this file with missing spanish accents.
Thank you!
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.