-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Add prose tests #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would like to enable these one-by-one so we can make small PRs to enable rules and fix some of the warnings.
|
I'm going to merge this now and start submitting some small PRs to fix the current warnings. |
aseel-aaa
added a commit
to aseel-aaa/opensource.guide
that referenced
this pull request
Nov 1, 2025
# This is the 1st commit message: Arabic translation for how to contribute # This is the commit message github#2: Fix anchor text # This is the commit message github#3: anchor Text again # This is the commit message github#4: anchor text again # This is the commit message github#5: Fix blanks # This is the commit message #6: fix blanks X100 # This is the commit message github#7: edit blank # This is the commit message github#8: editing # This is the commit message github#9: editing2 # This is the commit message github#10: add arabic translation for maintaining-balance-for-open-source-maintainers # This is the commit message github#11: some changes on maintainingArticle # This is the commit message github#12: changes * # This is the commit message github#13: Maha Work # This is the commit message github#14: 3 new articles # This is the commit message github#15: edit quotes # This is the commit message github#16: added 2 articles # This is the commit message github#17: fix anchor text # This is the commit message #18: afnan work # This is the commit message #19: translated 2 new articles by afnan # This is the commit message github#20: fix anchor text # This is the commit message github#21: Arabic translation: starting-a-project.md by wafaa # This is the commit message #22: translated starting-a-project # This is the commit message github#23: some changes # This is the commit message github#24: translated legal # This is the commit message github#25: fix anchor text # This is the commit message github#26: fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
script/test-prose, which uses several node packages that check for proper english, readability, insensitive language, and phrases that could be simplified.It's all very configurable, so as we develop a clearer styleguide, we could add more checks to this. I'm not sure that we'd ever want to enforce these checks, but it's at least helpful to see them.
Note that this PR is based on the content in #8, so it includes that in the diff as well.
Here's the output: