Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jekyll to v3.9.4 #897

Closed
wants to merge 1 commit into from
Closed

Bump jekyll to v3.9.4 #897

wants to merge 1 commit into from

Conversation

parkr
Copy link
Contributor

@parkr parkr commented Dec 28, 2023

Adds Ruby 3.3 support. (https://github.com/jekyll/jekyll/releases/tag/v3.9.4)

@yoannchaudet, if you'd like to bring support up to Ruby 3.3, this tiny v3.9.4 release has been made available for you!

@parkr parkr mentioned this pull request Jan 4, 2024
@parkr
Copy link
Contributor Author

parkr commented Jan 4, 2024

That's odd. The tests in spec didn't run.

@dorianmariecom
Copy link

+1 I was getting:

14:38:58 web.1  | jekyll 3.9.3 | Error:  undefined method `[]' for nil
14:38:58 web.1  | /Users/dorianmariefr/.asdf/installs/ruby/3.3.0/lib/ruby/3.3.0/logger.rb:384:in `level': undefined method `[]' for nil (NoMethodError)
14:38:58 web.1  | 
14:38:58 web.1  |     @level_override[Fiber.current] || @level
14:38:58 web.1  |                    ^^^^^^^^^^^^^^^
14:38:58 web.1  | 	from /Users/dorianmariefr/.asdf/installs/ruby/3.3.0/lib/ruby/gems/3.3.0/gems/jekyll-3.9.3/lib/jekyll/log_adapter.rb:43:in `adjust_verbosity'
14:38:58 web.1  | 	from /Users/dorianmariefr/.asdf/installs/ruby/3.3.0/lib/ruby/gems/3.3.0/gems/jekyll-3.9.3/lib/jekyll/configuration.rb:157:in `config_files'
14:38:58 web.1  | 	from /Users/dorianmariefr/.asdf/installs/ruby/3.3.0/lib/ruby/gems/3.3.0/gems/jekyll-3.9.3/lib/jekyll.rb:113:in `configuration'

@yoannchaudet
Copy link
Contributor

This made it into #898.

@parkr parkr deleted the jekyll-3-9-4 branch February 6, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants