This repository has been archived by the owner on Apr 21, 2022. It is now read-only.
Set html, body, and content to height-full
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophshep
previously requested changes
Mar 5, 2019
brandonrosage
changed the title
height-full
brandonrosage
dismissed
sophshep’s stale review
Changes address Sophie's concerns
IgnacioCarrionN
added a commit
to IgnacioCarrionN/ignaciocarrionn.github.io
that referenced
this pull request
May 29, 2019
* Use og:image to display avatar So social sharing crawlers pickup a useful image * Add Instagram and Unsplash * Add Instagram and Unsplash * Update Size of Icon for instagram * Update Colors * Update URL for Instagram * Update Readme explaining #48 * Revert "Merge pull request github#58 from lucario/patch-1" This reverts commit c934c47, reversing changes made to 7f7e377. * slipped in small mistake in README * Fix an issue missing page height * Adds hackerrank to social media links. * Fixes order to be alphabetical. * Add about Jekyll_github_token * Implement Changes * fixes issue with social media icons offcentered * added custom class identifier as well * add: website * added more og tags; dynamic page title * removed empty line * revised language about API authentication * replaced custom CSS with liquid condition * changed label to `website`; defined SVG * Fixes order to be alphabetical in social media. * Adds Keybase to social media * Updated REAMDE with correct social media ordering. * Don't require @ symbol for Medium profiles * Fix overlapping tooltips Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com> * fix primary metadata margins * exclude archived repositories * Add Mastodon to social media Add Mastodon to social media * Add Mastodon to social media Add Mastodon to social media * Fixed Stack Overflow's URL Added `HTTPS` instead of `HTTP`, issue #125 . * init venue labels workflow * Revert "init venue labels workflow" This reverts commit 7e022e0. * fix margins & padding for blockquotes, lists and nested lists * Fix: remove rbenv specific version If you are using rbenv and you try to `bundle install`: ``` % bundle install rbenv: version `2.5.1' is not installed (set by /var/home/michele/personal-website/.ruby-version) ``` With this PR we do not restrict users to have that particular version of Ruby installed via rbenv. Tested and works with: ``` % rbenv versions system * 2.6.3 ``` * Fix: add .ruby-version to .gitignore * added example to config.yml
l4u23n7p
pushed a commit
to l4u23n7p/l4u23n7p.github.io
that referenced
this pull request
Jun 21, 2019
sowderca
added a commit
to sowderca/sowderca.github.io
that referenced
this pull request
Feb 19, 2020
* Delete generated code * feat: sort repo by pushed date * Add links to stargazers and forks * Add Language colors for the repositories. Used colors.json from https://github.com/ozh/github-colors/blob/master/colors.json to get the latest colors for each of the languages and then added to the repo-card with the language and a circle for the color. Add link around the Language to be the same as the Stars and forks. Change the order of the language to match GitHub. * Make stargazers and forks stick to bottom of repo cards * remove duplicated repository owner name all over the site showing the repo owner name repeatedly is not adding any value for the site. * Adds Description Tag * Escaping XML * Change top style {1 => 2}px. The color did not appear to be even with the text therefore, changed the color to have a top of 2px instead of 1px. * feat: enable rouge highlighter * Fix spelling mistake in description * Add missing command to steps to serve the website Add `bundle install` command to steps list in order to get the website running * Update README.md * replaced absolute positioning approach with flexbox * Make stargazers and forks stick to bottom of repo cards * revise .gitignore for _site/ * re-remove _site/ * styles for `.article` body content; published: false * renamed `syntax.scss` to be a little more explicit and descriptive * support baseurl in path to posts and back home * add jemoji gem; remove Gemfile.lock * added social_media data file, and conditional loop * Update styles.scss * add support for dynamic "share" links on posts * fixed stacked layout for social masthead; efficient post_body * Imrpove wording * Add parameter for sorting project cards * Add parameter to exclude forks and specified projects * restore language metadata to repo cards Fixes github#28 (comment) * add article blockquote style Closes https://github.com/github/personal-website/issues/62 * add .emoji styles * add closing CSS bracket * Use primer class to set height to full * Add social media instructions to README * Add Dribbble URL * Remove Rubik * Give GitHub creit for primer * docs about customization * Change usernames to placeholders, add Dribbble reference in README * Add missing verb * Polished and filled out social media documentation Also deleted unecessary gemspec file * slipped in reference to "by default" This is intended to clarify that the appearance of your website is not fixed, and that you should read on for additional options. * slipped in small mistake in README * tightened up YAML structure and taxonomy for `projects` * added support for customizable `limit`; added supporting docs * add behance to yaml * add tooltips to social links; improve SVGs; add comments to config * Refactor social share solution Removes share_url include and includes share URL previs in datalist * debug share logic * - Adding the limit of interest as a config * Renaming the interest list to interests * Revert "Renaming the interest list to interests" This reverts commit 04e92d8. * Revert "- Adding the limit of interest as a config" This reverts commit d95c9d9. * Removing the limit of topics * Add Medium * Add to README * alphabetical order * Fix broken links * Update README with changes * fix mixed content * Use og:image to display avatar So social sharing crawlers pickup a useful image * Add Instagram and Unsplash * Add Instagram and Unsplash * Update Size of Icon for instagram * Update Colors * Update URL for Instagram * Update Readme explaining #48 * Add Telegram and VK * Synchronize _data/colors.json with lib/linguist/languages.yml * Revert "Merge pull request github#58 from lucario/patch-1" This reverts commit c934c47, reversing changes made to 7f7e377. * slipped in small mistake in README * Fix an issue missing page height * Adds hackerrank to social media links. * Fixes order to be alphabetical. * Add about Jekyll_github_token * Implement Changes * fixes issue with social media icons offcentered * added custom class identifier as well * add: website * added more og tags; dynamic page title * removed empty line * revised language about API authentication * replaced custom CSS with liquid condition * changed label to `website`; defined SVG * Fixes order to be alphabetical in social media. * Adds Keybase to social media * Updated REAMDE with correct social media ordering. * Don't require @ symbol for Medium profiles * Fix overlapping tooltips Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com> * fix primary metadata margins * exclude archived repositories * Add Mastodon to social media Add Mastodon to social media * Add Mastodon to social media Add Mastodon to social media * Fixed Stack Overflow's URL Added `HTTPS` instead of `HTTP`, issue #125 . * init venue labels workflow * Revert "init venue labels workflow" This reverts commit 7e022e0. * fix margins & padding for blockquotes, lists and nested lists * Fix: remove rbenv specific version If you are using rbenv and you try to `bundle install`: ``` % bundle install rbenv: version `2.5.1' is not installed (set by /var/home/michele/personal-website/.ruby-version) ``` With this PR we do not restrict users to have that particular version of Ruby installed via rbenv. Tested and works with: ``` % rbenv versions system * 2.6.3 ``` * Fix: add .ruby-version to .gitignore * added example to config.yml Co-authored-by: Frieder Bluemle <frieder.bluemle@gmail.com> Co-authored-by: Aung Myo Kyaw <aungmyokyaw.dev@gmail.com> Co-authored-by: Marko Kunic <kunicmarko20@gmail.com> Co-authored-by: Cory <cshay237@gmail.com> Co-authored-by: Brendan Le Glaunec <brendan.le-glaunec@epitech.eu> Co-authored-by: Sreekanth Boddireddy <happysreekanth@gmail.com> Co-authored-by: James Ives <iam@jamesiv.es> Co-authored-by: Wilfried JEANNIARD <willou.com@gmail.com> Co-authored-by: Francisc Furdui <francisc.furdui2@mail.dcu.ie> Co-authored-by: Esteban De la Rosa <gabbanaesteban@gmail.com> Co-authored-by: monomagentaeggroll <32424535+monomagentaeggroll@users.noreply.github.com> Co-authored-by: Brandon Rosage <brandonrosage@github.com> Co-authored-by: JakeConnors376W <46732192+JakeConnors376W@users.noreply.github.com> Co-authored-by: Brett Stevenson <BStevensonDev@gmail.com> Co-authored-by: James Vanderburg <james@vanderburg.org> Co-authored-by: Aadi Bajpai <me@aadibajpai.me> Co-authored-by: Sophie Shepherd <sophshep@github.com> Co-authored-by: Ouadie BOUSSAID <ouadie.boussaid@gmail.com> Co-authored-by: Brian Surowiec <brian@13degrees.com> Co-authored-by: Tony Brix <tony@brix.ninja> Co-authored-by: Jordy van den Aardweg <jordyvandenaardweg@gmail.com> Co-authored-by: Matej Plavevski <matej.plavevski+github@gmail.com> Co-authored-by: Daniil Suvorov <severecloud@gmail.com> Co-authored-by: Ryo Ota <nwtgck@nwtgck.org> Co-authored-by: Tsubasa Takayama <tsubasatakayama511@gmail.com> Co-authored-by: Jack Vincent <mail@jack.geek.nz> Co-authored-by: Landon Patmore <landon.patmore@gmail.com> Co-authored-by: Dayan Ruben Gonzalez <dayanrubengb@gmail.com> Co-authored-by: Alex Saveau <saveau.alexandre@gmail.com> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh> Co-authored-by: Geezus42 <Geezuslucifer@gmail.com> Co-authored-by: Bailey Matthews <baileyjmatthews@gmail.com> Co-authored-by: Michele Bologna <michele.bologna@gmail.com>
danreeves
added a commit
to danreeves/danreeves.github.io
that referenced
this pull request
Apr 3, 2020
* Delete generated code * feat: sort repo by pushed date * Add links to stargazers and forks * Add Language colors for the repositories. Used colors.json from https://github.com/ozh/github-colors/blob/master/colors.json to get the latest colors for each of the languages and then added to the repo-card with the language and a circle for the color. Add link around the Language to be the same as the Stars and forks. Change the order of the language to match GitHub. * Make stargazers and forks stick to bottom of repo cards * remove duplicated repository owner name all over the site showing the repo owner name repeatedly is not adding any value for the site. * Adds Description Tag * Escaping XML * Change top style {1 => 2}px. The color did not appear to be even with the text therefore, changed the color to have a top of 2px instead of 1px. * feat: enable rouge highlighter * Fix spelling mistake in description * Add missing command to steps to serve the website Add `bundle install` command to steps list in order to get the website running * Update README.md * replaced absolute positioning approach with flexbox * Make stargazers and forks stick to bottom of repo cards * revise .gitignore for _site/ * re-remove _site/ * styles for `.article` body content; published: false * renamed `syntax.scss` to be a little more explicit and descriptive * support baseurl in path to posts and back home * add jemoji gem; remove Gemfile.lock * added social_media data file, and conditional loop * Update styles.scss * add support for dynamic "share" links on posts * fixed stacked layout for social masthead; efficient post_body * Imrpove wording * Add parameter for sorting project cards * Add parameter to exclude forks and specified projects * restore language metadata to repo cards Fixes github#28 (comment) * add article blockquote style Closes https://github.com/github/personal-website/issues/62 * add .emoji styles * add closing CSS bracket * Use primer class to set height to full * Add social media instructions to README * Add Dribbble URL * Remove Rubik * Give GitHub creit for primer * docs about customization * Change usernames to placeholders, add Dribbble reference in README * Add missing verb * Polished and filled out social media documentation Also deleted unecessary gemspec file * slipped in reference to "by default" This is intended to clarify that the appearance of your website is not fixed, and that you should read on for additional options. * slipped in small mistake in README * tightened up YAML structure and taxonomy for `projects` * added support for customizable `limit`; added supporting docs * add behance to yaml * add tooltips to social links; improve SVGs; add comments to config * Refactor social share solution Removes share_url include and includes share URL previs in datalist * debug share logic * - Adding the limit of interest as a config * Renaming the interest list to interests * Revert "Renaming the interest list to interests" This reverts commit 04e92d8. * Revert "- Adding the limit of interest as a config" This reverts commit d95c9d9. * Removing the limit of topics * Add Medium * Add to README * alphabetical order * Fix broken links * Update README with changes * fix mixed content * Use og:image to display avatar So social sharing crawlers pickup a useful image * Add Instagram and Unsplash * Add Instagram and Unsplash * Update Size of Icon for instagram * Update Colors * Update URL for Instagram * Update Readme explaining #48 * Add Telegram and VK * Synchronize _data/colors.json with lib/linguist/languages.yml * Revert "Merge pull request github#58 from lucario/patch-1" This reverts commit c934c47, reversing changes made to 7f7e377. * slipped in small mistake in README * Fix an issue missing page height * Adds hackerrank to social media links. * Fixes order to be alphabetical. * Add about Jekyll_github_token * Implement Changes * fixes issue with social media icons offcentered * added custom class identifier as well * add: website * added more og tags; dynamic page title * removed empty line * revised language about API authentication * replaced custom CSS with liquid condition * changed label to `website`; defined SVG * Fixes order to be alphabetical in social media. * Adds Keybase to social media * Updated REAMDE with correct social media ordering. * Don't require @ symbol for Medium profiles * Fix overlapping tooltips Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com> * fix primary metadata margins * exclude archived repositories * Add Mastodon to social media Add Mastodon to social media * Add Mastodon to social media Add Mastodon to social media * Fixed Stack Overflow's URL Added `HTTPS` instead of `HTTP`, issue #125 . * init venue labels workflow * Revert "init venue labels workflow" This reverts commit 7e022e0. * fix margins & padding for blockquotes, lists and nested lists * Fix: remove rbenv specific version If you are using rbenv and you try to `bundle install`: ``` % bundle install rbenv: version `2.5.1' is not installed (set by /var/home/michele/personal-website/.ruby-version) ``` With this PR we do not restrict users to have that particular version of Ruby installed via rbenv. Tested and works with: ``` % rbenv versions system * 2.6.3 ``` * Fix: add .ruby-version to .gitignore * added example to config.yml Co-authored-by: Frieder Bluemle <frieder.bluemle@gmail.com> Co-authored-by: Aung Myo Kyaw <git@aungmyokyaw.com> Co-authored-by: Marko Kunic <kunicmarko20@gmail.com> Co-authored-by: ccsplit <cshay237@gmail.com> Co-authored-by: Ullaakut <brendan.le-glaunec@epitech.eu> Co-authored-by: Sreekanth Boddireddy <happysreekanth@gmail.com> Co-authored-by: James Ives <iam@jamesiv.es> Co-authored-by: Wilfried JEANNIARD <willou.com@gmail.com> Co-authored-by: Francisc Furdui <francisc.furdui2@mail.dcu.ie> Co-authored-by: Esteban De la Rosa <gabbanaesteban@gmail.com> Co-authored-by: monomagentaeggroll <32424535+monomagentaeggroll@users.noreply.github.com> Co-authored-by: Brandon Rosage <brandonrosage@github.com> Co-authored-by: lucario <matthewburnett@riolu.com> Co-authored-by: JakeConnors376W <46732192+JakeConnors376W@users.noreply.github.com> Co-authored-by: tterb <bstevensondev@gmail.com> Co-authored-by: James Vanderburg <james@vanderburg.org> Co-authored-by: Aadi Bajpai <aadibajpai@gmail.com> Co-authored-by: Sophie Shepherd <sophshep@github.com> Co-authored-by: Boussaid, Ouadie <ouadie@amazon.com> Co-authored-by: Ouadie <ouadie@outlook.com> Co-authored-by: Brian Surowiec <xtorted@optonline.net> Co-authored-by: Tony Brix <tbrix13+github.com@gmail.com> Co-authored-by: Jordy van den Aardweg <jordyvandenaardweg@gmail.com> Co-authored-by: matejmecka <matej.plavevski+github@gmail.com> Co-authored-by: Suvorov Daniil <severecloud@gmail.com> Co-authored-by: Ryo Ota <nwtgck@gmail.com> Co-authored-by: Tsubasa Takayama <tsubasatakayama511@gmail.com> Co-authored-by: Jack Vincent <mail@jack.geek.nz> Co-authored-by: Landon Patmore <landon.patmore@gmail.com> Co-authored-by: Sam Klein <sk@pine.guru> Co-authored-by: Dayan Ruben Gonzalez <dayanrubengb@gmail.com> Co-authored-by: Alex Saveau <saveau.alexandre@gmail.com> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh> Co-authored-by: Geezus <geezuslucifer@gmail.com> Co-authored-by: Bailey Matthews <baileyjmatthews@gmail.com> Co-authored-by: Patrik Hagara <phagara@redhat.com> Co-authored-by: Michele Bologna <michele.bologna@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks more correct to me, I'm not sure if the previous design was intentional or not.