Enhanced Secrets Redaction Support - More Patterns 🔑 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobe4
approved these changes
May 20, 2024
There was a problem hiding this comment.
Looks good 👍
If possible that would be nice to include a reference for each pattern, pointing to the official doc showcasing the format.
E.g. https://developer.hashicorp.com/vault/tutorials/tokens/tokens?variants=vault-deploy:hcp#token-prefix
(note that in this page, it lists more possible vault prefixes, so your vault example is incomplete)
nobe4
reviewed
May 20, 2024
Co-authored-by: nobe4 <nobe4@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced Secrets Redaction Support - More Patterns 🔑
This pull request adds more regex patterns to redact new types of secrets.
The follow secrets will now be redacted by this gem when using the default configuration: