Skip to content

Per-experiment sampling? #70

Open
Open
@jamesbrauman

Description

@jamesbrauman

When using the science method in the Scientist module, I want to supply an extra parameter that would be used inside the enabled? method to determine whether to run the experiment.

The intention is to be able to control, on a per-experiment basis, the percentage of time that the experiment will actually run.

Is something like this possible?

Activity

jbarnette

jbarnette commented on Aug 22, 2017

@jbarnette
Contributor

@jamesbrauman That's a good idea! There's no interface for it right now, but I dig it.

jamesbrauman

jamesbrauman commented on Aug 23, 2017

@jamesbrauman
Author

@jbarnette Thanks for replying. For further information, I'm presently doing something like this to achieve what I want:

science 'experiment-name' do |e|
  e.context percentage_enabled: 5
end

And then in the enabled? method in my experiment, I am doing:

def enabled?
  if context.key?(:percent_enabled)
    # ...
  else
    true
  end
end

And my preferred way of doing it would be to pass that to the science call:

science 'experiment-name', percent_enabled: 5 do |e|
  # ...
end

Would you like me to make a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @jbarnette@jamesbrauman

        Issue actions

          Per-experiment sampling? · Issue #70 · github/scientist