Fix hash generation for indented helper methods #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper outputs the closing </script> or </style> unindented if it is on its own line. Needed to remove any extra whitespace the regex captures on that last line.
|
Thanks!
🤔 I'll put some thought into it but I'm also happy to merge and release (with a note that this is experimental at best). |
|
I tested this out locally and it works with all kinds of wonky spacing. I'll merge/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helper outputs the closing
</script>or</style>unindentedif it is on its own line. Needed to remove any extra whitespace
the regex captures on that last line.
All PRs:
Has tests
Honestly, I wasn't sure how to test this without also refactoring the entire rake task.
Documentation updated
Didn't think any documentation needed to be updated since this is really just working better now.
Related to comments in #432, though maybe not the original issue.