Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable warnings in tests #149

Merged
merged 4 commits into from
Jun 14, 2019
Merged

Enable warnings in tests #149

merged 4 commits into from
Jun 14, 2019

Conversation

jhrcek
Copy link
Contributor

@jhrcek jhrcek commented Jun 14, 2019

Still work in progress on #127.
Checking how this will behave in CI.

patrickt
patrickt approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@patrickt patrickt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there are more warnings to add, this looks good to me!

@patrickt patrickt merged commit 1afb36c into github:master Jun 14, 2019
@jhrcek
Copy link
Contributor Author

jhrcek commented Jun 14, 2019

I'm going to fix some of those warnings in tests in the followup PR

This was referenced Jun 15, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickt patrickt patrickt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhrcek @patrickt