fix(scripts): prevent create-new-feature branch-number parse failure#1593
Open
ignatremizov wants to merge 1 commit intogithub:mainfrom
Open
fix(scripts): prevent create-new-feature branch-number parse failure#1593ignatremizov wants to merge 1 commit intogithub:mainfrom
ignatremizov wants to merge 1 commit intogithub:mainfrom
Conversation
The branch number is computed via command substitution when create-new-feature.sh runs check_existing_branches. In some environments git fetch prints 'Fetching ...' to stdout, which was captured into BRANCH_NUMBER and later caused arithmetic expansion failures like '10#Fetching'. Redirect fetch stdout and stderr to /dev/null inside check_existing_branches so only the numeric value is returned. This keeps behavior unchanged aside from eliminating the noisy-output failure mode. Refs: github#1592
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents scripts/bash/create-new-feature.sh --json from failing when git fetch writes status text to stdout during branch-number auto-detection, ensuring the command substitution used to compute BRANCH_NUMBER remains numeric-only.
Changes:
- Redirect
git fetch --all --prunestdout + stderr to/dev/nullinsidecheck_existing_branchesto avoid contaminating captured output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create-new-feature.shfrom capturinggit fetch --alloutput intoBRANCH_NUMBER10#Fetching: value too great for baseRoot Cause
check_existing_branchesruns in command substitution and previously called:This suppresses stderr but not stdout. In environments where fetch prints status text to stdout (for example
Fetching ...), that text can be captured alongside the numeric return value and later break numeric parsing.Fix
Changed fetch redirection to suppress both stdout and stderr:
This keeps behavior the same while ensuring
check_existing_branchesemits only the intended numeric value.Validation
spec-kitrepo:bash scripts/bash/create-new-feature.sh --json "test fetch output capture fix"10#Fetchingerrorvue-tailwind-datepicker) against localspec-kitscript:bash /Users/iremizov/code/spec-kit/scripts/bash/create-new-feature.sh --json "verify fetch output fix from external repo"10#FetchingerrorAI Disclosure
This PR was prepared with AI assistance (OpenAI Codex
gpt-5.3-codex high), then reviewed and validated by me.Closes #1592