Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header seperator count #177

Merged
merged 1 commit into from
Jul 8, 2024
Merged

fix: header seperator count #177

merged 1 commit into from
Jul 8, 2024

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Jul 8, 2024

Pull Request

fixes #176

Proposed Changes

This pull request fixes the functionality of the write_to_markdown function in stale_repos.py and its corresponding tests in test_stale_repos.py. The main changes involve the proper handling of recently added optional metrics ("Days Since Last Release" and "Days Since Last PR") in the markdown output and the corresponding updates in the test cases.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

Signed-off-by: Zack Koppert <zkoppert@github.com>
@zkoppert zkoppert requested review from jmeridth and sutterj as code owners July 8, 2024 23:01
@github-actions github-actions bot added the fix label Jul 8, 2024
@zkoppert zkoppert merged commit d9dc177 into main Jul 8, 2024
26 checks passed
@zkoppert zkoppert deleted the header-fix branch July 8, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown Table output is "off"
2 participants